Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Navbar Items Responsiveness for Mobile View #4197

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

M-DEV-1
Copy link
Contributor

@M-DEV-1 M-DEV-1 commented Dec 28, 2024

Description

This PR fixes problem #4196 by including media queries on all mobile views. Now, navbar elements adjust to the mobile width and appear correctly.

All sub-menus (including the accessibility menu) can now be opened and utilized without overlapping.

Screenshots

Screen Size: iPhone 14 Pro Max

iPhone 14 Pro Max

Screen Size: Samsung Z Fold 5

Samsung Z Fold 5

Checklist:

  • My changes adhere to the project's contribution guidelines.
  • Code changes are implemented.
  • Navbar responsiveness works as expected.

@M-DEV-1 M-DEV-1 changed the title Fix Navbar Items Responsives for Mobile View Fix Navbar Items Responsiveness for Mobile View Dec 28, 2024
@M-DEV-1
Copy link
Contributor Author

M-DEV-1 commented Dec 30, 2024

@walterbender sir, please review these changes when possible. thank you.

@walterbender
Copy link
Member

This is a big improvement.

There is still a problem with some intermediary sizes. Maybe we can adjust things in a separate PR.

Screenshot From 2024-12-30 09-18-10
Screenshot From 2024-12-30 09-18-25

@walterbender walterbender merged commit d121f38 into sugarlabs:master Dec 30, 2024
@M-DEV-1
Copy link
Contributor Author

M-DEV-1 commented Dec 30, 2024

thank you @walterbender sir, will work on fixing the remaining issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants