Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crearting 'View Trash' option in Musicblocks #4191

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

subhas-pramanik-09
Copy link
Contributor

resolves #4190

I have created a new Restore option in Musicblocks ( View Trash ). From here we can see the list of all trashed items. By selecting item from the list the specific item will be restored. We don't need to restore item multiple time to restore the specific item from trash.

Screen Record

Screen.Recording.2024-12-27.175506.mp4

@subhas-pramanik-09
Copy link
Contributor Author

@walterbender Sir, I think it will definitely help users. Please check it.

Copy link

@AliyanA1 AliyanA1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good

@walterbender
Copy link
Member

I like the basic idea (we have something similiar in the Python version of Turtle Blocks). But I am loath to add yet another button to the toolbar. Maybe this is the default behavior of the restore button? @pikurasa what do you think?

@subhas-pramanik-09
Copy link
Contributor Author

I like the basic idea (we have something similiar in the Python version of Turtle Blocks). But I am loath to add yet another button to the toolbar. Maybe this is the default behavior of the restore button? @pikurasa what do you think?

Sir which should be the default behavior previous functionality or the functionality in this PR ?

@subhas-pramanik-09
Copy link
Contributor Author

@walterbender @pikurasa Sir can we add this feature to the current Restore button so we don't need to create a new button in toolbar again.

@walterbender
Copy link
Member

Let's wait to hear from @pikurasa

@pikurasa
Copy link
Collaborator

I think that the implementation in the python Turtle Art is better than this, and I think, if we do it at all, we should do it more similar to that.

I think the design should be:

  • There is a single trash button.
  • When you click the trash button, you see all the items that are in the trash bin, like you can see items in a palette.
  • Unlike the palette, you get some special buttons, such as "restore last" and "restore all". These buttons should probably be sticky at the top of the palette.
  • "Restore last" behaves the way our current "Restore" works, and "restore all" restores all the items in the trash.
  • (For now, we can just implement "restore last". We can implement "restore all" later. And we can discuss whether or not we want to be able to "empty trash" as you can with Turtle Art.)

@subhas-pramanik-09
Copy link
Contributor Author

Okay I am working on it.

@subhas-pramanik-09
Copy link
Contributor Author

@walterbender @pikurasa Sir, I have changed it like this. If any changes required please let me know

Screen.Recording.2024-12-31.004222.mp4

@pikurasa
Copy link
Collaborator

@walterbender @pikurasa Sir, I have changed it like this. If any changes required please let me know
Screen.Recording.2024-12-31.004222.mp4

I like that design, in general.

The blocks showing as black and white; I can't decide on whether that's a good thing or not. It may be nice that they don't render in color, as that kind of indicates that they are " currently trashed".

@walterbender
Copy link
Member

Looks good. I think the only change would be to put the buttons all the way to the top so the blocks don't appear above the buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement of restore items option in Musicblocks
4 participants