used async/syntax for better readability & performance #4144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified fetch event handling
retrogtx
reviewed
Dec 15, 2024
| console.log("[PWA Builder] Caching pages during install"); | ||
| return cache.addAll(precacheFiles); | ||
| }) | ||
| ); | ||
| }); | ||
|
|
||
| // Allow sw to control of current page | ||
| self.addEventListener("activate", function (event) { | ||
| // eslint-disable-next-line no-console |
There was a problem hiding this comment.
why did you remove this line?
|
Did I? Let me check
…On Sun, 15 Dec, 2024, 6:27 pm amrit, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In sw.js
<#4144 (comment)>
:
> console.log("[PWA Builder] Caching pages during install");
return cache.addAll(precacheFiles);
})
);
});
-// Allow sw to control of current page
-self.addEventListener("activate", function (event) {
- // eslint-disable-next-line no-console
why did you remove this line?
—
Reply to this email directly, view it on GitHub
<#4144 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6J4JNXZIV3FUICQKS3IBGT2FV4C5AVCNFSM6AAAAABTTWHUB2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBUGU2TCMBRGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Can you please elaborate on the what and why of your changes? |
|
|
you just need to test the file it looks good but attaching a working video of music blocks will be good enough since you have not added any description |
|
Yes. Please explain why and how you tested your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified fetch event handling