-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crearting 'View Trash' option in Musicblocks #4191
base: master
Are you sure you want to change the base?
Conversation
@walterbender Sir, I think it will definitely help users. Please check it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good
I like the basic idea (we have something similiar in the Python version of Turtle Blocks). But I am loath to add yet another button to the toolbar. Maybe this is the default behavior of the restore button? @pikurasa what do you think? |
Sir which should be the default behavior previous functionality or the functionality in this PR ? |
@walterbender @pikurasa Sir can we add this feature to the current Restore button so we don't need to create a new button in toolbar again. |
Let's wait to hear from @pikurasa |
I think that the implementation in the python Turtle Art is better than this, and I think, if we do it at all, we should do it more similar to that. I think the design should be:
|
Okay I am working on it. |
@walterbender @pikurasa Sir, I have changed it like this. If any changes required please let me know Screen.Recording.2024-12-31.004222.mp4 |
I like that design, in general. The blocks showing as black and white; I can't decide on whether that's a good thing or not. It may be nice that they don't render in color, as that kind of indicates that they are " currently trashed". |
resolves #4190
I have created a new Restore option in Musicblocks ( View Trash ). From here we can see the list of all trashed items. By selecting item from the list the specific item will be restored. We don't need to restore item multiple time to restore the specific item from trash.
Screen Record
Screen.Recording.2024-12-27.175506.mp4