-
Notifications
You must be signed in to change notification settings - Fork 115
chore: bump kona to kona-client/v1.2.0 #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Performance Comparison (ELF: eigenda-range-elf-embedded)Range 2751087~2751092
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch for taking care of this.
Left a question and a few reminders before moving on.
By the way, shouldn't the cycle-count-diffCI job be passing now with kona v.1.2.0?
| hokulea-compute-proof = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| hokulea-eigenda = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| hokulea-host-bin = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| hokulea-proof = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| hokulea-witgen = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| hokulea-zkvm-verification = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| canoe-sp1-cc-host = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| canoe-sp1-cc-verifier = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| canoe-verifier-address-fetcher = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder to update these to head once your PR in hokulea is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it should be blocking for merging this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there’s no rush and they’re planning to merge today or tomorrow, let’s hold off for now.
| hokulea-compute-proof = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| hokulea-eigenda = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| hokulea-host-bin = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| hokulea-proof = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| hokulea-witgen = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| hokulea-zkvm-verification = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| canoe-sp1-cc-host = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| canoe-sp1-cc-verifier = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } | ||
| canoe-verifier-address-fetcher = { git = "https://github.com/Layr-Labs/hokulea", rev = "e93d73d2207055a0fa89469d14845cbd0139fbe9" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it should be blocking for merging this PR?
Bumping to Jovian ready release of the kona-client.