Adding Location Search#100
Open
jhd3197 wants to merge 7 commits intosubzeroid:masterfrom
jhd3197:master
Open
Conversation
Adding blur and adjusting some default parameters
When location is set in post its doing a location search for the lat and picking the first one sometimes works sometimes it doesn't so i added a patch for that and also the TopSearchesPublicMixin.top_search was broken because it was doing a public request when it should be a private request
adding location_search_pk and location_search_name
adw0rd
suggested changes
Mar 16, 2021
Contributor
adw0rd
left a comment
adw0rd
left a comment
There was a problem hiding this comment.
- Why need storyUpload in photo_upload? Use photo_upload_to_story for uploading photo to story
- extract_locationV2 - broken naming in the project (use extract_location_v2)
- Error using private requests in a public module, this makes no sense (You use private_request in public.py module)
- The rest of the functions for working with GEO (location) will still need to be checked, I did not see any tests on them
adw0rd
suggested changes
Mar 16, 2021
|
|
||
| * `path` - Path to source file | ||
| * `caption` - Text for you post | ||
| * `storyUpload` - If True will create a story from image (default: False) |
Contributor
There was a problem hiding this comment.
Why need storyUpload in photo_upload? Use photo_upload_to_story for uploading photo to story
| "include_reel": "true", | ||
| } | ||
| response = self.public_request(url, params=params, return_json=True) | ||
| response = self.private_request(url, params=params) |
Contributor
There was a problem hiding this comment.
Error using private requests in a public module, this makes no sense (You use private_request in public.py module)
|
|
||
|
|
||
| def extract_locationV2(data): | ||
| """Extract location info""" |
Contributor
There was a problem hiding this comment.
extract_locationV2 - broken naming in the project (use extract_location_v2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.