Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize code #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Optimize code #7

wants to merge 3 commits into from

Conversation

thetiagogil
Copy link
Collaborator

@thetiagogil thetiagogil commented Jan 22, 2025

This PR is mostly just dropping the overuse of the sx prop of Joy UI components (this change comes now because I was waiting for your opinion on the custom Flexbox!).

  • Change from using sx prop to using the proper props in Joy UI components.
  • Add colors.ts file to better keep track of all the colors being used in the app.
  • Update theme.ts file.
  • Fix bugs/errors (moslty related to svg icons).

@thetiagogil thetiagogil changed the base branch from main to add-onboarding-pages January 22, 2025 16:30
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for sub-strengths ready!

Name Link
🔨 Latest commit ce75a09
🔍 Latest deploy log https://app.netlify.com/sites/sub-strengths/deploys/67936f3486e3e20008612fc2
😎 Deploy Preview https://deploy-preview-7--sub-strengths.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Base automatically changed from add-onboarding-pages to main January 24, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant