Heinrichs Weikamp: Log the Remaining Scrubber Time on OSTC 4/5. #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to log the remaining scrubber run time along with warnings and errors upon reaching scrubber limits, and it enhances compass heading messages to include the heading value.
- Introduces new fields in the parser structure to track scrubber times and error/warning flags.
- Implements new switch-case handling for scrubber time reporting and updates compass heading event processing.
- Adjusts error messaging to correctly detect buffer underflow conditions.
Comments suppressed due to low confidence (1)
src/hw_ostc_parser.c:819
- [nitpick] The use of literal case numbers (6 and 7) for scrubber time reporting can reduce code clarity. Consider defining constants or an enumeration for these cases to improve maintainability.
case 6:
mikeller
force-pushed
the
add_ostc4_scrubber_logging
branch
4 times, most recently
from
1103cce to
8aeff74
Compare
Log the remaining scrubber run time, and warnings and errors when reaching the limits. Also add the compass heading value to compass heading messages. Requires mikeller/ostc4#32 to work. Signed-off-by: Michael Keller <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Michael Keller <[email protected]>
mikeller
force-pushed
the
add_ostc4_scrubber_logging
branch
from
8aeff74 to
9efc929
Compare
Member
Author
|
Verified against OSTC 4/5 firmware 1.7.2. |
theCarlG
pushed a commit
to theCarlG/libdc
that referenced
this pull request
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log the remaining scrubber run time, and warnings and errors when
reaching the limits.
Also add the compass heading value to compass heading messages.
Requires mikeller/ostc4#32 to work.
Signed-off-by: Michael Keller [email protected]