Add support for a new Sirius profile version #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After upgrading a Mares Sirius to firmware version 1.6.16, the profile version changed to v2.0. Surprisingly, despite the change in the major version number, there appear to be no functional changes in the data format. Signed-off-by: rmultan <[email protected]> (cherry picked from commit 82712ce)
Contributor
|
hi @mikeller Are you planning to merge this somewhen soon? |
Member
Author
|
This will have to go in after subsurface/subsurface#4494, as this already contains a change in the |
theCarlG
pushed a commit
to theCarlG/libdc
that referenced
this pull request
Jul 16, 2025
…pport Add support for a new Sirius profile version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading a Mares Sirius to firmware version 1.6.16, the profile
version changed to v2.0. Surprisingly, despite the change in the major
version number, there appear to be no functional changes in the data
format.
Signed-off-by: rmultan [email protected]
(cherry picked from commit 82712ce)