feat(extensions): add fp16, decimal256, and duration extension types#978
Draft
kadinrabo wants to merge 17 commits intosubstrait-io:mainfrom
Draft
feat(extensions): add fp16, decimal256, and duration extension types#978kadinrabo wants to merge 17 commits intosubstrait-io:mainfrom
kadinrabo wants to merge 17 commits intosubstrait-io:mainfrom
Conversation
nielspardon
reviewed
Mar 25, 2026
Member
There was a problem hiding this comment.
What is the difference between duration and the interval_year / interval_day data types?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three numeric extension types as self-contained modules following the pattern from #953 (unsigned integers). Each file defines types with string structure encoding and arithmetic function overloads.
float16.yaml: fp16 with add, subtract, multiply, divide, sum, min, maxdecimal256.yaml: decimal256<precision, scale> with add, subtract, multiply, divide, modulus, abs, sum, min, max, avgduration.yaml: duration with add, subtract, sum, min, maxThese types are already defined in Arrow's
extension_types.yamland are currently encoded in DataFusion viatype_variation_reference, which violates the spec's "same semantics" requirement for type variations.Depends on #953.
This change is