Skip to content

sub-77: fix: order attributes not set when subscription order is created #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Khalevksyi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

sub-77: fix: order attributes not set when subscription order is created #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cartridges/int_subscribe_pro_sfra/cartridge/controllers/SubPro.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ server.post('UpdateOptions', function (req, res, next) {
}

basket.custom.subproSubscriptionsToBeProcessed = isSubpro;
basket.custom.subproContainsSubscriptions = isSubpro;

res.json(new CartModel(basket));
});
Expand Down
4 changes: 4 additions & 0 deletions cartridges/int_subscribe_pro_sfra/cartridge/scripts/subpro/hooks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
{
"name": "dw.ocapi.shop.order.validateOrder",
"script": "./hooks/order.js"
},
{
"name": "dw.ocapi.shop.basket.afterPost",
"script": "./hooks/basket.js"
}
]
}
20 changes: 20 additions & 0 deletions cartridges/int_subscribe_pro_sfra/cartridge/scripts/subpro/hooks/basket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
'use strict';

var Status = require('dw/system/Status');

/**
* afterPost
* @param {dw.order.Basket} basket - basket
* @returns {Status} a non-null Status ends the hook execution
*/
function afterPost(basket) {
if (basket.custom.subproIsRecurringOrder) {
basket.custom.subproContainsSubscriptions = true;
}

return new Status(Status.OK);
}

module.exports = {
afterPost: afterPost
};
Binary file modified metadata/site_import.zip
View file
Open in desktop
Binary file not shown.
8 changes: 8 additions & 0 deletions metadata/site_import/meta/system-objecttype-extensions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,12 +227,20 @@
<mandatory-flag>false</mandatory-flag>
<externally-managed-flag>false</externally-managed-flag>
</attribute-definition>
<attribute-definition attribute-id="subproIsRecurringOrder">
<display-name xml:lang="x-default">Subpro Is Recurring Order</display-name>
<type>boolean</type>
<localizable-flag>false</localizable-flag>
<mandatory-flag>false</mandatory-flag>
<externally-managed-flag>false</externally-managed-flag>
</attribute-definition>
</custom-attribute-definitions>
<group-definitions>
<attribute-group group-id="subscribe-pro">
<display-name xml:lang="x-default">Subscribe Pro</display-name>
<attribute attribute-id="subproContainsSubscriptions"/>
<attribute attribute-id="subproSubscriptionsToBeProcessed"/>
<attribute attribute-id="subproIsRecurringOrder"/>
</attribute-group>
</group-definitions>
</type-extension>
Expand Down