[Python] Fix first case statement termination#4440
Merged
deathaxe merged 1 commit intosublimehq:masterfrom Feb 25, 2026
Merged
Conversation
This commit ... 1. fixes first incomplete case statement failing valid 2nd case statement due to calling `fail` outside of a branch point. That's caused by first case statement re-using contexts of common case statements. 2. fixes first statement after `match ...:` being scoped wrong, when starting with `case` soft keyword, by implementing first case statement with same branching strategy as all other ones. Notes: 1. As a side effect all case statements are highlighted the same way. 2. Previously introduced special context `after-first-case-statement` becomes obsolete and is removed.
michaelblyons
approved these changes
Feb 11, 2026
jrappen
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ...
fixes first incomplete case statement failing valid 2nd case statement due to calling
failoutside of a branch point. That's caused by first case statement re-using contexts of common case statements.fixes first statement after
match ...:being scoped wrong, when starting withcasesoft keyword, by implementing first case statement with same branching strategy as all other ones.Notes:
after-first-case-statementbecomes obsolete and is removed.