[Python] Extend comment punctuation#4438
Merged
deathaxe merged 3 commits intosublimehq:masterfrom Mar 3, 2026
Merged
Conversation
This commit copes all leading and trailing # signs in comments `punctuation.definition.comment` to... 1. ensure ST's enter key to work as expected in case of comments starting with multiple ## 2. ensure same highlighting of all leading # signs. Even though, technically only the first # defines the comment, highlighting all the same just looks more consistent. 3. (2) also applies to trailing #. Despite not having a semantic meaning, separating comments just look more consistent with trailing # scoped punctuation.
`expressions-in-a-statement` context is terminated by comments. Thus including patterns to consume them is redundant.
michaelblyons
previously approved these changes
Feb 25, 2026
Collaborator
michaelblyons
left a comment
michaelblyons
left a comment
There was a problem hiding this comment.
I think this is fine, but I would understand objections to it.
FichteFoll
previously approved these changes
Mar 1, 2026
michaelblyons
approved these changes
Mar 2, 2026
FichteFoll
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit copes all leading and trailing # signs in comments
punctuation.definition.commentto...Before
After