Fix grouping for top-level static modules#91
Open
BananaAccurate wants to merge 1 commit into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Author
|
Maintainer-ready closeout evidence for PR #91:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engine/antigravity_engine/hub/module_grouping.pyso artifact detection is evaluated relative to the module root.static/eligible for grouping while still excluding nested generated/static artifact directories.staticmodule with a nested generatedstaticdirectory.Why
A workspace can have a real top-level
static/source module. The previous artifact check evaluated absolute path parts, so any file under that module was skipped becausestaticappeared in the full path. That caused refresh to load zero files for the module and produce no group agents.Validation
python -m pytest tests/test_hub_module_grouping.py -qpassed: 9 passed.python -m pytest -qwas also run; 219 passed and 5 failed for pre-existing environment/platform reasons unrelated to this patch: missing async pytest plugin handling forpytest.mark.asynciotests and a Windows POSIX permission-mode assertion.engine/withpython -m pip install --user --no-deps --force-reinstall .succeeded.static/app.jsloads whilestatic/nested/static/generated.jsremains excluded.