Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IdentityVerification Example to allow for reusing VerificationSessions #4427

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

aywang-stripe
Copy link
Contributor

Summary

Updates Identity Verification Example app to allow for reusing VerificationSessions. Reusing VerificationSessions is a common pattern for Stripe Identity users.

Motivation

Allow for better testing of all of the possible integration paths that an integrator may implement.

Testing

Tested in simulator to validate new behavior

Screen.Recording.2024-12-23.at.2.39.11.PM.mov

Changelog

  • [Added] Updates example app to allow reusing VerificationSessions.

Copy link

⚠️ Public API changes detected:

StripePaymentSheet

- case embeddedPaymentElementAlreadyConfirmedIntent

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

Copy link

emerge-tools bot commented Dec 23, 2024

8 builds had no size change

Name Version Download Change Install Change Approval
StripeSize
com.stripe.StripeSize
1.0 (1) 2.1 MB ⬆️ 2 B 7.0 MB - N/A
StripePaymentsSize
com.stripe.StripePaymentsSize
1.0 (1) 1.2 MB ⬆️ 1 B 4.2 MB - N/A
StripePaymentsUISize
com.stripe.StripePaymentsUISize
1.0 (1) 1.9 MB ⬆️ 6 B 6.4 MB - N/A
StripePaymentSheetSize
com.stripe.StripePaymentSheetSize
1.0 (1) 3.8 MB ⬇️ 6 B 11.1 MB - N/A
StripeIdentitySize
com.stripe.StripeIdentitySize
1.0 (1) 1.4 MB - 4.3 MB - N/A
StripeApplePaySize
com.stripe.StripeApplePaySize
1.0 (1) 482.7 kB - 1.7 MB - N/A
StripeFinancialConnectionsSize
com.stripe.StripeFinancialConnectionsSize
1.0 (1) 1.4 MB ⬆️ 2 B 4.5 MB - N/A
StripeConnectSize
com.stripe.StripeConnectSize
1.0 (1) 1.5 MB ⬇️ 1 B 5.0 MB - N/A

StripeSize 1.0 (1)
com.stripe.StripeSize

No changes to report

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

No changes to report

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

No changes to report

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize

No changes to report

StripeIdentitySize 1.0 (1)
com.stripe.StripeIdentitySize

No changes to report

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

No changes to report

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

No changes to report

StripeConnectSize 1.0 (1)
com.stripe.StripeConnectSize

No changes to report


🛸 Powered by Emerge Tools

Copy link
Collaborator

@yuki-stripe yuki-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to update w/ latest master

@aywang-stripe aywang-stripe force-pushed the aywang/identity-example-reuse-verification branch from 570b5e4 to aa78ebb Compare January 9, 2025 18:49
@aywang-stripe aywang-stripe merged commit 62a6b5b into master Jan 9, 2025
7 checks passed
@aywang-stripe aywang-stripe deleted the aywang/identity-example-reuse-verification branch January 9, 2025 19:18
Comment on lines +30 to +32
### Identity
* [Added] Updates example app to allow reusing VerificationSessions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops this ended up in the wrong place, it should be at the top of the file where pending changes are listed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, fixing in #4451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants