Address code review feedback

Fix layout issue with super-long bank name and validate with screenshot test.

paymentsheet/src/main/java/com/stripe/android/paymentsheet/paymentdatacollection/ach/USBankAccountForm.kt

@@ -27,6 +27,7 @@ import androidx.compose.ui.platform.testTag
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.input.ImeAction
+import androidx.compose.ui.text.style.TextOverflow
 import androidx.compose.ui.unit.dp
 import androidx.lifecycle.viewmodel.compose.viewModel
 import com.stripe.android.paymentsheet.PaymentSheet.BillingDetailsCollectionConfiguration.AddressCollectionMode
@@ -396,6 +397,7 @@ private fun AccountDetailsForm(
                 Row(
                     verticalAlignment = Alignment.CenterVertically,
                     horizontalArrangement = Arrangement.spacedBy(8.dp),
+                    modifier = Modifier.weight(1f)
                 ) {
                     Image(
                         painter = painterResource(bankIcon),
@@ -405,8 +407,11 @@ private fun AccountDetailsForm(
 
                     Text(
                         text = "$bankName •••• $last4",
-                        modifier = Modifier.alpha(if (isProcessing) 0.5f else 1f),
                         color = MaterialTheme.stripeColors.onComponent,
+                        overflow = TextOverflow.Ellipsis,
+                        modifier = Modifier
+                            .alpha(if (isProcessing) 0.5f else 1f)
+                            .weight(1f, fill = false),
                     )
 
                     promoBadgeState?.let { badgeState ->

paymentsheet/src/test/java/com/stripe/android/paymentsheet/paymentdatacollection/ach/AccountPreviewScreenshotTest.kt

@@ -143,6 +143,32 @@ internal class AccountPreviewScreenshotTest {
         }
     }
 
+    @Test
+    fun testWithPromoBadgeNextToSuperLongAccountName() {
+        paparazzi.snapshot {
+            BankAccountForm(
+                state = BankFormScreenStateFactory.createWithSession(
+                    sessionId = "session_1234",
+                    promoText = "$5",
+                    eligibleForPromo = false,
+                    bankName = "SuperDuperUltraLongBankName",
+                ),
+                instantDebits = true,
+                isPaymentFlow = true,
+                formArgs = formArguments,
+                nameController = createNameController(),
+                emailController = createEmailController(),
+                phoneController = createPhoneNumberController(),
+                addressController = createAddressController(fillAddress = false),
+                sameAsShippingElement = sameAsShippingElement,
+                saveForFutureUseElement = saveForFutureUseElement,
+                showCheckbox = false,
+                lastTextFieldIdentifier = null,
+                onRemoveAccount = {},
+            )
+        }
+    }
+
     @Test
     fun testWithIneligiblePromoBadge() {
         paparazzi.snapshot {

paymentsheet/src/test/java/com/stripe/android/utils/BankFormScreenStateFactory.kt

@@ -13,13 +13,15 @@ internal object BankFormScreenStateFactory {
         mandateText: ResolvableString = "Some legal text".resolvableString,
         promoText: String? = null,
         eligibleForPromo: Boolean = true,
+        bankName: String = "Stripe Bank",
     ): BankFormScreenState {
         return create(
             resultIdentifier = BankFormScreenState.ResultIdentifier.Session(sessionId),
             isVerifyingWithMicrodeposits = isVerifyingWithMicrodeposits,
             mandateText = mandateText,
             promoText = promoText,
             eligibleForPromo = eligibleForPromo,
+            bankName = bankName,
         )
     }
 
@@ -43,14 +45,15 @@ internal object BankFormScreenStateFactory {
         mandateText: ResolvableString,
         promoText: String?,
         eligibleForPromo: Boolean,
+        bankName: String = "Stripe Bank",
     ): BankFormScreenState {
         return BankFormScreenState(
             isPaymentFlow = true,
             linkedBankAccount = BankFormScreenState.LinkedBankAccount(
                 resultIdentifier = resultIdentifier,
                 financialConnectionsSessionId = "session_1234",
                 intentId = "intent_1234",
-                bankName = "Stripe Bank",
+                bankName = bankName,
                 last4 = "6789",
                 mandateText = mandateText,
                 isVerifyingWithMicrodeposits = isVerifyingWithMicrodeposits,