Add and update tests

Add tests in `RealCreateInstantDebitsResultTest` to ensure the endpoint is called correctly.
stripe · Dec 9, 2024 · 2d0ba4c · 2d0ba4c
1 parent 3be015b
commit 2d0ba4c
Show file tree

Hide file tree

Showing 14 changed files with 186 additions and 9 deletions.
diff --git a/...ncial-connections/src/test/java/com/stripe/android/financialconnections/ApiKeyFixtures.kt b/...ncial-connections/src/test/java/com/stripe/android/financialconnections/ApiKeyFixtures.kt
@@ -152,6 +152,7 @@ internal object ApiKeyFixtures {
     )
 
     fun consumerSessionSignup() = ConsumerSessionSignup(
+        accountId = "acct_123",
         publishableKey = "pk_123",
         consumerSession = consumerSession().copy(
             verificationSessions = listOf(
@@ -163,7 +164,10 @@ internal object ApiKeyFixtures {
         ),
     )
 
-    fun cachedConsumerSession() = CachedConsumerSession(
+    fun cachedConsumerSession(
+        accountId: String? = null,
+    ) = CachedConsumerSession(
+        accountId = accountId,
         clientSecret = "clientSecret",
         emailAddress = "[email protected]",
         phoneNumber = "(***) *** **12",

diff --git a/.../test/java/com/stripe/android/financialconnections/domain/PollAttachPaymentAccountTest.kt b/.../test/java/com/stripe/android/financialconnections/domain/PollAttachPaymentAccountTest.kt
@@ -108,6 +108,7 @@ internal class PollAttachPaymentAccountTest {
     )
 
     private fun cachedConsumerSession() = CachedConsumerSession(
+        accountId = null,
         clientSecret = "clientSecret",
         emailAddress = "[email protected]",
         isVerified = true,

diff --git a/.../java/com/stripe/android/financialconnections/domain/RealCreateInstantDebitsResultTest.kt b/.../java/com/stripe/android/financialconnections/domain/RealCreateInstantDebitsResultTest.kt
@@ -1,21 +1,27 @@
 package com.stripe.android.financialconnections.domain
 
+import com.google.common.truth.Truth.assertThat
 import com.stripe.android.financialconnections.FinancialConnectionsSheet.ElementsSessionContext
 import com.stripe.android.financialconnections.FinancialConnectionsSheet.ElementsSessionContext.BillingDetails
 import com.stripe.android.financialconnections.repository.CachedConsumerSession
 import com.stripe.android.financialconnections.repository.FinancialConnectionsConsumerSessionRepository
 import com.stripe.android.financialconnections.repository.FinancialConnectionsRepository
 import com.stripe.android.model.ConsumerPaymentDetails
+import com.stripe.android.model.IncentiveEligibilitySession
+import com.stripe.android.model.LinkConsumerIncentive
 import com.stripe.android.model.LinkMode
 import com.stripe.android.model.SharePaymentDetails
 import kotlinx.coroutines.test.runTest
 import org.junit.Test
 import org.mockito.kotlin.any
 import org.mockito.kotlin.anyOrNull
 import org.mockito.kotlin.doReturn
+import org.mockito.kotlin.eq
 import org.mockito.kotlin.mock
+import org.mockito.kotlin.never
 import org.mockito.kotlin.verify
 import org.mockito.kotlin.verifyNoInteractions
+import org.mockito.kotlin.whenever
 
 class RealCreateInstantDebitsResultTest {
 
@@ -167,6 +173,96 @@ class RealCreateInstantDebitsResultTest {
         )
     }
 
+    @Test
+    fun `Skips checking available incentives if not incentive eligible`() = runTest {
+        val consumerRepository = makeConsumerSessionRepository()
+        val repository = makeRepository()
+
+        val createInstantDebitResult = RealCreateInstantDebitsResult(
+            consumerRepository = consumerRepository,
+            repository = repository,
+            consumerSessionProvider = { makeCachedConsumerSession("acct_789") },
+            elementsSessionContext = makeElementsSessionContext(
+                linkMode = LinkMode.LinkPaymentMethod,
+                incentiveEligibilitySession = null,
+            ),
+        )
+
+        val result = createInstantDebitResult("bank_account_id_001")
+
+        verify(consumerRepository, never()).updateAvailableIncentives(
+            sessionId = any(),
+            consumerAccount = any(),
+        )
+
+        assertThat(result.eligibleForIncentive).isFalse()
+    }
+
+    @Test
+    fun `Skips checking available incentives if no signup happened in the flow`() = runTest {
+        val consumerRepository = makeConsumerSessionRepository()
+        val repository = makeRepository()
+
+        val createInstantDebitResult = RealCreateInstantDebitsResult(
+            consumerRepository = consumerRepository,
+            repository = repository,
+            consumerSessionProvider = {
+                // A missing account ID means no signup happened
+                makeCachedConsumerSession(accountId = null)
+            },
+            elementsSessionContext = makeElementsSessionContext(
+                linkMode = LinkMode.LinkPaymentMethod,
+                incentiveEligibilitySession = IncentiveEligibilitySession.PaymentIntent("pi_123"),
+            ),
+        )
+
+        val result = createInstantDebitResult("bank_account_id_001")
+
+        verify(consumerRepository, never()).updateAvailableIncentives(
+            sessionId = any(),
+            consumerAccount = any(),
+        )
+
+        assertThat(result.eligibleForIncentive).isFalse()
+    }
+
+    @Test
+    fun `Checks available incentives if eligible`() = runTest {
+        val consumerRepository = makeConsumerSessionRepository()
+        val repository = makeRepository()
+
+        val createInstantDebitResult = RealCreateInstantDebitsResult(
+            consumerRepository = consumerRepository,
+            repository = repository,
+            consumerSessionProvider = { makeCachedConsumerSession("acct_789") },
+            elementsSessionContext = makeElementsSessionContext(
+                linkMode = LinkMode.LinkPaymentMethod,
+                incentiveEligibilitySession = IncentiveEligibilitySession.PaymentIntent("pi_123"),
+            ),
+        )
+
+        whenever(
+            consumerRepository.updateAvailableIncentives(
+                sessionId = eq("pi_123"),
+                consumerAccount = eq("acct_789"),
+            )
+        ).thenReturn(
+            UpdateAvailableIncentives(
+                data = listOf(
+                    LinkConsumerIncentive(
+                        incentiveParams = LinkConsumerIncentive.IncentiveParams(
+                            paymentMethod = "link_instant_debits",
+                        ),
+                        incentiveDisplayText = "$5",
+                    )
+                )
+            )
+        )
+
+        val result = createInstantDebitResult("bank_account_id_001")
+        assertThat(result.eligibleForIncentive).isTrue()
+    }
+
     private fun makeConsumerSessionRepository(): FinancialConnectionsConsumerSessionRepository {
         val consumerPaymentDetails = ConsumerPaymentDetails(
             paymentDetails = listOf(
@@ -199,8 +295,11 @@ class RealCreateInstantDebitsResultTest {
         }
     }
 
-    private fun makeCachedConsumerSession(): CachedConsumerSession {
+    private fun makeCachedConsumerSession(
+        accountId: String? = null,
+    ): CachedConsumerSession {
         return CachedConsumerSession(
+            accountId = accountId,
             clientSecret = "clientSecret",
             emailAddress = "[email protected]",
             phoneNumber = "(***) *** **12",
@@ -212,6 +311,7 @@ class RealCreateInstantDebitsResultTest {
     private fun makeElementsSessionContext(
         linkMode: LinkMode?,
         billingDetails: BillingDetails? = null,
+        incentiveEligibilitySession: IncentiveEligibilitySession? = null,
     ): ElementsSessionContext {
         return ElementsSessionContext(
             amount = 100L,
@@ -223,7 +323,7 @@ class RealCreateInstantDebitsResultTest {
                 phone = null,
                 phoneCountryCode = null,
             ),
-            incentiveEligibilitySession = null,
+            incentiveEligibilitySession = incentiveEligibilitySession,
         )
     }
 }
diff --git a/.../stripe/android/financialconnections/features/accountpicker/AccountPickerViewModelTest.kt b/.../stripe/android/financialconnections/features/accountpicker/AccountPickerViewModelTest.kt
@@ -277,6 +277,7 @@ internal class AccountPickerViewModelTest {
     @Test
     fun `Saves selected accounts to Link if we have a consumer session`() = runTest {
         val consumerSession = CachedConsumerSession(
+            accountId = null,
             clientSecret = "clientSecret",
             emailAddress = "[email protected]",
             phoneNumber = "(***) *** **12",

diff --git a/...id/financialconnections/launcher/FinancialConnectionsSheetForInstantDebitsLauncherTest.kt b/...id/financialconnections/launcher/FinancialConnectionsSheetForInstantDebitsLauncherTest.kt
@@ -23,6 +23,7 @@ class FinancialConnectionsSheetForInstantDebitsLauncherTest {
                 encodedPaymentMethod = encodedPaymentMethod,
                 last4 = "1234",
                 bankName = "Bank of America",
+                eligibleForIncentive = false,
             )
         )
 
@@ -46,6 +47,7 @@ class FinancialConnectionsSheetForInstantDebitsLauncherTest {
                             encodedPaymentMethod = encodedPaymentMethod,
                             last4 = "1234",
                             bankName = "Bank of America",
+                            eligibleForIncentive = false,
                         )
                     )
             }

diff --git a/...android/financialconnections/presentation/FinancialConnectionsSheetNativeViewModelTest.kt b/...android/financialconnections/presentation/FinancialConnectionsSheetNativeViewModelTest.kt
@@ -327,6 +327,7 @@ internal class FinancialConnectionsSheetNativeViewModelTest {
                     encodedPaymentMethod = encodedPaymentMethod,
                     last4 = "4242",
                     bankName = "Stripe Bank",
+                    eligibleForIncentive = false,
                 )
             },
         )
@@ -339,6 +340,7 @@ internal class FinancialConnectionsSheetNativeViewModelTest {
                     encodedPaymentMethod = encodedPaymentMethod,
                     last4 = "4242",
                     bankName = "Stripe Bank",
+                    eligibleForIncentive = false,
                 ),
             )
         )
@@ -382,6 +384,7 @@ internal class FinancialConnectionsSheetNativeViewModelTest {
                     encodedPaymentMethod = encodedPaymentMethod,
                     last4 = "4242",
                     bankName = "Stripe Bank",
+                    eligibleForIncentive = false,
                 )
             },
         )

diff --git a/.../financialconnections/repository/FinancialConnectionsConsumerSessionRepositoryImplTest.kt b/.../financialconnections/repository/FinancialConnectionsConsumerSessionRepositoryImplTest.kt
@@ -75,6 +75,7 @@ class FinancialConnectionsConsumerSessionRepositoryImplTest {
         )
 
         val consumerSessionSignup = ConsumerSessionSignup(
+            accountId = "acct_123",
             consumerSession = consumerSession,
             publishableKey = "pk_123",
         )
@@ -111,6 +112,7 @@ class FinancialConnectionsConsumerSessionRepositoryImplTest {
         // ensures there's a cached consumer session after the signup call.
         assertThat(repository.getCachedConsumerSession()).isEqualTo(
             CachedConsumerSession(
+                accountId = "acct_123",
                 clientSecret = "clientSecret",
                 emailAddress = "[email protected]",
                 phoneNumber = "(•••) ••• ••12",
@@ -132,6 +134,7 @@ class FinancialConnectionsConsumerSessionRepositoryImplTest {
         )
 
         val consumerSessionSignup = ConsumerSessionSignup(
+            accountId = "acct_123",
             consumerSession = consumerSession,
             publishableKey = "pk_123",
         )
@@ -212,6 +215,7 @@ class FinancialConnectionsConsumerSessionRepositoryImplTest {
         // ensures there's a cached consumer session after the lookup call.
         assertThat(repository.getCachedConsumerSession()).isEqualTo(
             CachedConsumerSession(
+                accountId = null,
                 clientSecret = "clientSecret",
                 emailAddress = "[email protected]",
                 phoneNumber = "(•••) ••• ••12",
@@ -267,6 +271,7 @@ class FinancialConnectionsConsumerSessionRepositoryImplTest {
         // ensures there's a cached consumer session after the start-verification call.
         assertThat(repository.getCachedConsumerSession()).isEqualTo(
             CachedConsumerSession(
+                accountId = null,
                 clientSecret = "clientSecret",
                 emailAddress = "[email protected]",
                 phoneNumber = "(•••) ••• ••12",
@@ -316,6 +321,7 @@ class FinancialConnectionsConsumerSessionRepositoryImplTest {
         // ensures there's a cached consumer session after the confirm-verification call.
         assertThat(repository.getCachedConsumerSession()).isEqualTo(
             CachedConsumerSession(
+                accountId = null,
                 clientSecret = "clientSecret",
                 emailAddress = "[email protected]",
                 phoneNumber = "(•••) ••• ••12",

diff --git a/...a/com/stripe/android/financialconnections/repository/RealConsumerSessionRepositoryTest.kt b/...a/com/stripe/android/financialconnections/repository/RealConsumerSessionRepositoryTest.kt
@@ -20,6 +20,7 @@ class RealConsumerSessionRepositoryTest {
         val cachedSession = store.provideConsumerSession()
         assertThat(cachedSession).isEqualTo(
             CachedConsumerSession(
+                accountId = null,
                 emailAddress = "[email protected]",
                 phoneNumber = "(•••) •••-1234",
                 clientSecret = "abc_123",
@@ -42,6 +43,7 @@ class RealConsumerSessionRepositoryTest {
         val cachedSession = store.provideConsumerSession()
         assertThat(cachedSession).isEqualTo(
             CachedConsumerSession(
+                accountId = null,
                 emailAddress = "[email protected]",
                 phoneNumber = "(•••) •••-1234",
                 clientSecret = "abc_123",
@@ -52,7 +54,7 @@ class RealConsumerSessionRepositoryTest {
     }
 
     @Test
-    fun `Keeps existing publishable key when storing updated consumer session`() {
+    fun `Keeps existing publishable key and account ID when storing updated consumer session`() {
         val store = RealConsumerSessionRepository(savedStateHandle = SavedStateHandle())
 
         val session1 = makeConsumerSession(
@@ -65,12 +67,13 @@ class RealConsumerSessionRepositoryTest {
             isVerified = true,
         )
 
-        store.storeNewConsumerSession(session1, publishableKey = "pk_123")
+        store.storeNewConsumerSession(session1, publishableKey = "pk_123", accountId = "acct_123")
         store.updateConsumerSession(session2)
 
         val cachedSession = store.provideConsumerSession()
         assertThat(cachedSession).isEqualTo(
             CachedConsumerSession(
+                accountId = "acct_123",
                 emailAddress = "[email protected]",
                 phoneNumber = "(•••) •••-1234",
                 clientSecret = "abc_123",
@@ -94,12 +97,13 @@ class RealConsumerSessionRepositoryTest {
             isVerified = false,
         )
 
-        store.storeNewConsumerSession(session1, publishableKey = "pk_123")
-        store.storeNewConsumerSession(session2, publishableKey = "pk_456")
+        store.storeNewConsumerSession(session1, publishableKey = "pk_123", accountId = "acct_123")
+        store.storeNewConsumerSession(session2, publishableKey = "pk_456", accountId = "acct_456")
 
         val cachedSession = store.provideConsumerSession()
         assertThat(cachedSession).isEqualTo(
             CachedConsumerSession(
+                accountId = "acct_456",
                 emailAddress = "[email protected]",
                 phoneNumber = "(•••) •••-1234",
                 clientSecret = "abc_456",

diff --git a/...om/stripe/android/financialconnections/repository/api/RealProvideApiRequestOptionsTest.kt b/...om/stripe/android/financialconnections/repository/api/RealProvideApiRequestOptionsTest.kt
@@ -106,6 +106,7 @@ class RealProvideApiRequestOptionsTest {
         publishableKey: String?,
     ): CachedConsumerSession {
         return CachedConsumerSession(
+            accountId = null,
             clientSecret = "clientSecret",
             emailAddress = "[email protected]",
             phoneNumber = "(***) *** **12",

diff --git a/link/src/test/java/com/stripe/android/link/TestFactory.kt b/link/src/test/java/com/stripe/android/link/TestFactory.kt
@@ -27,6 +27,7 @@ internal object TestFactory {
 
     const val EMAIL = "[email protected]"
     const val CLIENT_SECRET = "client_secret"
+    const val ACCOUNT_ID = "acct_123"
     const val PUBLISHABLE_KEY = "publishable_key"
     const val MERCHANT_NAME = "merchantName"
     const val CUSTOMER_EMAIL = "[email protected]"
@@ -55,6 +56,7 @@ internal object TestFactory {
     )
 
     val CONSUMER_SESSION_SIGN_UP = ConsumerSessionSignup(
+        accountId = ACCOUNT_ID,
         consumerSession = CONSUMER_SESSION,
         publishableKey = PUBLISHABLE_KEY
     )