Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention SDKs runner on build failures #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mention SDKs runner on build failures #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion actions/notify-slack/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,11 @@ runs:
uses: slackapi/[email protected]
with:
channel-id: 'developer-sdks-team-bots'
# cc's @developer-sdks-run
slack-message: >
❗ ${{ inputs.action }} *failed* (${{ job.status }})!
<${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|Job> |
<${{ github.event.pull_request.html_url || github.event.head_commit.url }}|Commit>
<${{ github.event.pull_request.html_url || github.event.head_commit.url }}|Commit> cc: <@S03C9B2JDDY>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we externalize the channel id into a parameter or variable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, but then we'll have to set it in every repo that uses this action. Given that we're the only users of this workflow, IMO it makes the most sense to hardcode it here. If we need to parameterize it, we can.

env:
SLACK_BOT_TOKEN: ${{ inputs.bot_token }}
if: >
Expand Down