Replace VertxUtil.completableFutureToVertxFuture with Future.fromCompletionStage

[scholzj]

Type of change

• Refactoring

Description

This PR replaces VertxUtil.completableFutureToVertxFuture with Future.fromCompletionStage and implements the required changes to exception handling and tests.

This should resolve #12456.

Checklist

• Make sure all tests pass
• Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
• Reference relevant issue(s) and close them after merging

[codecov]

Codecov Report

❌ Patch coverage is 82.45614% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.96%. Comparing base (d9d0773) to head (0b633e3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...ter/operator/assembly/AbstractConnectOperator.java	86.36%	2 Missing and 1 partial ⚠️
...perator/assembly/KafkaConnectAssemblyOperator.java	75.00%	1 Missing ⚠️
...or/assembly/KafkaMirrorMaker2AssemblyOperator.java	50.00%	1 Missing ⚠️
...rator/assembly/KafkaRebalanceAssemblyOperator.java	88.88%	0 Missing and 1 partial ⚠️
...or/cluster/operator/resource/KafkaQuorumCheck.java	0.00%	1 Missing ⚠️
...src/main/java/io/strimzi/operator/common/Util.java	50.00%	0 Missing and 1 partial ⚠️
.../operator/resource/concurrent/ResourceSupport.java	0.00%	1 Missing ⚠️
...imzi/operator/user/operator/KafkaUserOperator.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12579      +/-   ##
============================================
- Coverage     75.01%   74.96%   -0.06%     
+ Complexity     6434     6426       -8     
============================================
  Files           373      373              
  Lines         24881    24872       -9     
  Branches       3205     3204       -1     
============================================
- Hits          18665    18645      -20     
- Misses         4900     4907       +7     
- Partials       1316     1320       +4     

Files with missing lines	Coverage Δ
...o/strimzi/operator/cluster/operator/VertxUtil.java	91.48% <ø> (+0.41%)	⬆️
...erator/cluster/operator/assembly/CaReconciler.java	90.07% <100.00%> (ø)
...ter/operator/assembly/KafkaNodeUnregistration.java	81.08% <100.00%> (ø)
...perator/assembly/KafkaRebalanceConfigMapUtils.java	83.33% <100.00%> (ø)
...tor/cluster/operator/assembly/KafkaReconciler.java	94.52% <100.00%> (ø)
...r/cluster/operator/resource/KafkaAvailability.java	88.79% <100.00%> (ø)
...perator/cluster/operator/resource/KafkaRoller.java	76.86% <100.00%> (ø)
...a/io/strimzi/operator/user/UserControllerLoop.java	91.22% <100.00%> (ø)
...perator/assembly/KafkaConnectAssemblyOperator.java	87.00% <75.00%> (ø)
...or/assembly/KafkaMirrorMaker2AssemblyOperator.java	84.69% <50.00%> (ø)
... and 6 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[scholzj]

/gha run pipeline=regression

[github-actions]

⏳ System test verification started: link

The following 6 job(s) will be executed:

• regression-brokers-and-security-amd64 (oracle-vm-8cpu-32gb-x86-64)
• regression-operators-amd64 (oracle-vm-8cpu-32gb-x86-64)
• regression-operands-amd64 (oracle-vm-8cpu-32gb-x86-64)
• regression-brokers-and-security-arm64 (oracle-vm-8cpu-32gb-arm64)
• regression-operators-arm64 (oracle-vm-8cpu-32gb-arm64)
• regression-operands-arm64 (oracle-vm-8cpu-32gb-arm64)

Tests will start after successful build completion.

[github-actions]

❌ System test verification failed: link

[github-actions]

❌ System test verification failed: link

[github-actions]

❌ System test verification failed: link

[github-actions]

❌ System test verification failed: link

[scholzj]

/gha run pipeline=regression

[github-actions]

⏳ System test verification started: link

The following 6 job(s) will be executed:

• regression-brokers-and-security-amd64 (oracle-vm-8cpu-32gb-x86-64)
• regression-operators-amd64 (oracle-vm-8cpu-32gb-x86-64)
• regression-operands-amd64 (oracle-vm-8cpu-32gb-x86-64)
• regression-brokers-and-security-arm64 (oracle-vm-8cpu-32gb-arm64)
• regression-operators-arm64 (oracle-vm-8cpu-32gb-arm64)
• regression-operands-arm64 (oracle-vm-8cpu-32gb-arm64)

Tests will start after successful build completion.

[github-actions]

❌ System test verification failed: link

[github-actions]

🎉 System test verification passed: link