[ST] Fix FIPS check in case that ConfigMap is missing#12546
Open
im-konge wants to merge 1 commit intostrimzi:mainfrom
Open
[ST] Fix FIPS check in case that ConfigMap is missing#12546im-konge wants to merge 1 commit intostrimzi:mainfrom
im-konge wants to merge 1 commit intostrimzi:mainfrom
Conversation
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Member
Author
|
/gha run pipeline=acceptance |
|
⏳ System test verification started: link The following 2 job(s) will be executed:
Tests will start after successful build completion. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12546 +/- ##
============================================
- Coverage 75.00% 74.98% -0.03%
+ Complexity 6435 6430 -5
============================================
Files 373 373
Lines 24881 24881
Branches 3205 3205
============================================
- Hits 18663 18656 -7
- Misses 4903 4907 +4
- Partials 1315 1318 +3 🚀 New features to boost your workflow:
|
|
🎉 System test verification passed: link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This small PR fixes the check if the cluster where we are running our STs is FIPS - in case that the ConfigMap is missing, the check will throw NPE.
The fix should ensure that the
falseis returned in case that the ConfigMap is missing, otherwise the data are taking from CM.Checklist