Skip to content

Stop passing CA Secret names to Ca class#12538

Open
katheris wants to merge 1 commit intostrimzi:mainfrom
katheris:cleanupCaClass
Open

Stop passing CA Secret names to Ca class#12538
katheris wants to merge 1 commit intostrimzi:mainfrom
katheris:cleanupCaClass

Conversation

@katheris
Copy link
Member

Type of change

Select the type of your PR

  • Refactoring

Description

Although the CA Secret names help debugging problems the names of the Secret's are well known and passing them increases the complexity of the code.

Stop passing the explicit Secret names and instead refer to the CA names to reduce the number of parameters needed to initialise the Ca classes.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

Although the CA Secret names help debugging problems
the names of the Secret's are well known and passing
them increases the complexity of the code.

Stop passing the explicit Secret names and instead
refer to the CA names to reduce the number of parameters
needed to initialise the Ca classes.

Signed-off-by: Kate Stanley <11195226+katheris@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 36.84211% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.00%. Comparing base (e86dd36) to head (8e951cb).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...main/java/io/strimzi/operator/common/model/Ca.java 33.33% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #12538   +/-   ##
=========================================
  Coverage     74.99%   75.00%           
  Complexity     6435     6435           
=========================================
  Files           373      373           
  Lines         24881    24874    -7     
  Branches       3205     3205           
=========================================
- Hits          18660    18656    -4     
+ Misses         4905     4902    -3     
  Partials       1316     1316           
Files with missing lines Coverage Δ
...a/io/strimzi/operator/cluster/model/ClusterCa.java 92.30% <100.00%> (-0.12%) ⬇️
...erator/cluster/operator/assembly/CaReconciler.java 90.07% <ø> (-0.04%) ⬇️
...va/io/strimzi/operator/common/model/ClientsCa.java 0.00% <ø> (ø)
...io/strimzi/operator/user/model/KafkaUserModel.java 83.98% <ø> (-0.16%) ⬇️
...main/java/io/strimzi/operator/common/model/Ca.java 43.05% <33.33%> (-0.27%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@katheris katheris added this to the 1.0.0 milestone Mar 19, 2026
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. LGTM otherwise.

* Represents the Strimzi Clients CA
*/
public class ClientsCa extends Ca {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed?

@scholzj
Copy link
Member

scholzj commented Mar 22, 2026

/gha run pipeline=regression

@github-actions
Copy link

github-actions bot commented Mar 22, 2026

⏳ System test verification started: link

The following 6 job(s) will be executed:

  • regression-brokers-and-security-amd64 (oracle-vm-8cpu-32gb-x86-64)
  • regression-operators-amd64 (oracle-vm-8cpu-32gb-x86-64)
  • regression-operands-amd64 (oracle-vm-8cpu-32gb-x86-64)
  • regression-brokers-and-security-arm64 (oracle-vm-8cpu-32gb-arm64)
  • regression-operators-arm64 (oracle-vm-8cpu-32gb-arm64)
  • regression-operands-arm64 (oracle-vm-8cpu-32gb-arm64)

Tests will start after successful build completion.

@github-actions
Copy link

🎉 System test verification passed: link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants