Stop passing CA Secret names to Ca class#12538
Open
katheris wants to merge 1 commit intostrimzi:mainfrom
Open
Conversation
Although the CA Secret names help debugging problems the names of the Secret's are well known and passing them increases the complexity of the code. Stop passing the explicit Secret names and instead refer to the CA names to reduce the number of parameters needed to initialise the Ca classes. Signed-off-by: Kate Stanley <11195226+katheris@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12538 +/- ##
=========================================
Coverage 74.99% 75.00%
Complexity 6435 6435
=========================================
Files 373 373
Lines 24881 24874 -7
Branches 3205 3205
=========================================
- Hits 18660 18656 -4
+ Misses 4905 4902 -3
Partials 1316 1316
🚀 New features to boost your workflow:
|
scholzj
approved these changes
Mar 22, 2026
| * Represents the Strimzi Clients CA | ||
| */ | ||
| public class ClientsCa extends Ca { | ||
|
|
Member
|
/gha run pipeline=regression |
|
⏳ System test verification started: link The following 6 job(s) will be executed:
Tests will start after successful build completion. |
ppatierno
approved these changes
Mar 22, 2026
|
🎉 System test verification passed: link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
Although the CA Secret names help debugging problems the names of the Secret's are well known and passing them increases the complexity of the code.
Stop passing the explicit Secret names and instead refer to the CA names to reduce the number of parameters needed to initialise the Ca classes.
Checklist
Please go through this checklist and make sure all applicable tasks have been done