[system test] - Make it possible to use POSTGRES_IMAGE env #11044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: see-quick <[email protected]>
Frawless
reviewed
Jan 15, 2025
Comment on lines
+108
to
117
| try { | ||
| final String postgresYaml = Files.readString(Paths.get(POSTGRES_FILE_PATH)).replace( | ||
| "${POSTGRES_IMAGE}", Environment.POSTGRES_IMAGE | ||
| ); | ||
| Files.writeString(Paths.get(POSTGRES_FILE_PATH), postgresYaml); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Failed to update the Postgres deployment YAML", e); | ||
| } | ||
|
|
||
| cmdKubeClient(namespaceName).apply(POSTGRES_FILE_PATH); |
There was a problem hiding this comment.
isn't possible to load the content, change the value and apply it without storing it? I think we did it in several cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR changes downloading Postgres through the GCR mirror.
Checklist