Removed tracing related param which was used with OpenTracing only (#851

) Signed-off-by: Paolo Patierno <[email protected]>
strimzi · Nov 18, 2023 · 1c25cf3 · 1c25cf3
1 parent afcc7c7
commit 1c25cf3
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/src/main/java/io/strimzi/kafka/bridge/http/HttpSinkBridgeEndpoint.java b/src/main/java/io/strimzi/kafka/bridge/http/HttpSinkBridgeEndpoint.java
@@ -283,7 +283,7 @@ private void pollHandler(ConsumerRecords<K, V> records, Throwable ex, RoutingCon
         if (ex == null) {
 
             for (ConsumerRecord<K, V> record : records) {
-                tracing.handleRecordSpan(span, record);
+                tracing.handleRecordSpan(record);
             }
             span.inject(routingContext);
 

diff --git a/src/main/java/io/strimzi/kafka/bridge/tracing/NoopTracingHandle.java b/src/main/java/io/strimzi/kafka/bridge/tracing/NoopTracingHandle.java
@@ -33,7 +33,7 @@ public <K, V> SpanHandle<K, V> span(RoutingContext routingContext, String operat
     }
 
     @Override
-    public <K, V> void handleRecordSpan(SpanHandle<K, V> parentSpanHandle, ConsumerRecord<K, V> record) {
+    public <K, V> void handleRecordSpan(ConsumerRecord<K, V> record) {
     }
 
     @Override

diff --git a/src/main/java/io/strimzi/kafka/bridge/tracing/OpenTelemetryHandle.java b/src/main/java/io/strimzi/kafka/bridge/tracing/OpenTelemetryHandle.java
@@ -89,7 +89,7 @@ private SpanBuilder getSpanBuilder(RoutingContext routingContext, String operati
     }
 
     @Override
-    public <K, V> void handleRecordSpan(SpanHandle<K, V> parentSpanHandle, ConsumerRecord<K, V> record) {
+    public <K, V> void handleRecordSpan(ConsumerRecord<K, V> record) {
         String operationName = record.topic() + " " + MessageOperation.RECEIVE;
         SpanBuilder spanBuilder = get().spanBuilder(operationName);
         Context parentContext = propagator().extract(Context.current(), TracingUtil.toHeaders(record), MG);

diff --git a/src/main/java/io/strimzi/kafka/bridge/tracing/TracingHandle.java b/src/main/java/io/strimzi/kafka/bridge/tracing/TracingHandle.java
@@ -51,10 +51,9 @@ public interface TracingHandle {
      *
      * @param <K> key type
      * @param <V> value type
-     * @param parentSpanHandle parent span handle
      * @param record Kafka consumer record
      */
-    <K, V>  void handleRecordSpan(SpanHandle<K, V> parentSpanHandle, ConsumerRecord<K, V> record);
+    <K, V>  void handleRecordSpan(ConsumerRecord<K, V> record);
 
     /**
      * Add producer properties, if any.