Skip to content

editor: disable collapsible headings inside tables #8858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

editor: disable collapsible headings inside tables #8858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/editor/src/extensions/heading/heading.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,17 @@ export const Heading = TiptapHeading.extend({
if (typeof pos !== "number") return;

const resolvedPos = editor.state.doc.resolve(pos);
const calloutAncestor = findParentNodeClosestToPos(
resolvedPos,
(node) => node.type.name === "callout"
);
if (calloutAncestor) return;
const forbiddenParents = ["callout", "table"];
if (
forbiddenParents.some((type) =>
findParentNodeClosestToPos(
resolvedPos,
(node) => node.type.name === type
)
)
) {
return;
}

if (
isClickWithinBounds(
Expand Down
15 changes: 15 additions & 0 deletions packages/editor/styles/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,6 +983,21 @@ del.diffdel {
display: none;
}

.ProseMirror table h1::before,
.ProseMirror table h2::before,
.ProseMirror table h3::before,
.ProseMirror table h4::before,
.ProseMirror table h5::before,
.ProseMirror table h6::before,
.ProseMirror table h1::after,
.ProseMirror table h2::after,
.ProseMirror table h3::after,
.ProseMirror table h4::after,
.ProseMirror table h5::after,
.ProseMirror table h6::after {
display: none;
}

[data-hidden-under] {
display: none !important;
}
Expand Down
Loading