Added partial download functunality #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: src/app.service.ts modified: src/app.controller.ts modified: src/app.service.ts these are improvments to the server, now it can serve range requests and it will complete the job when the download is finished
not relevent to the server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey, just added an option to use partial downloads.
the change should not affect the way downloads are currentlly implemented
how it works?
it usses http partial content function using the Range header.
if you download without the range header, it will just download normally, If you add it, it will only download what is specified.
The header is used in the format of {Range : bytes=start-end}
you can either use {bytes=start-end} to download a specific part of the file or {bytes=start-} to download from the start point until the end of the file.
if you use the second method it will automaticlly recognise the download is completed and will mark it as so.
also added minor logging improvment and an api documentation.
the implemntation is on the application side, there is a way to make it server side I just cant bother cuz my head is burned lol