feat: Support permission init for control plane management volume #104
+176
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuteng
changed the title
ciiiii
reviewed
Dec 30, 2024
modules/aws/sn-volume-access/files/sn_volume_s3_bucket.json.tpl
Outdated
Show resolved
Hide resolved
modules/aws/sn-volume-access/files/sn_volume_s3_bucket.json.tpl
Outdated
Show resolved
Hide resolved
tuteng
commented
Dec 30, 2024
| } | ||
|
|
||
| module "sn_managed_cloud" { | ||
| source = "../../modules/aws/volume-access" |
There was a problem hiding this comment.
Will change it after this pr approve and merged
maxsxu
reviewed
Dec 30, 2024
maxsxu
reviewed
Dec 30, 2024
maxsxu
reviewed
Dec 30, 2024
maxsxu
reviewed
Dec 30, 2024
maxsxu
reviewed
Dec 30, 2024
maxsxu
reviewed
Dec 30, 2024
maxsxu
reviewed
Dec 30, 2024
maxsxu
reviewed
Dec 30, 2024
maxsxu
reviewed
Dec 30, 2024
maxsxu
reviewed
Dec 30, 2024
maxsxu
reviewed
Dec 30, 2024
maxsxu
reviewed
Dec 30, 2024
maxsxu
reviewed
Dec 30, 2024
ciiiii
reviewed
Dec 30, 2024
maxsxu
reviewed
Jan 2, 2025
modules/aws/volume-access/main.tf
Outdated
| } | ||
|
|
||
| resource "aws_iam_role" "access_bucket_role" { | ||
| name = "sn-${var.external_id}-${var.bucket}-${var.path}" |
There was a problem hiding this comment.
We need handle the situation that the S3 path can contain multi path separator, e.g, s3://test-snowflake/it_iceberg/data/streaming_ingest/GBQMaKNHsA/a1/
There was a problem hiding this comment.
And be noted that the IAM Role name length is restricted to up to 64 characters.
maxsxu
reviewed
Jan 2, 2025
Comment on lines
25
to
33
| variable "bucket" { | ||
| description = "User bucket name" | ||
| type = string | ||
| } | ||
|
|
||
| variable "path" { | ||
| description = "S3 bucket path" | ||
| type = string | ||
| } |
There was a problem hiding this comment.
We can make it as an array, so user just need to append new bucket to the array rather than define a new terraform module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.