feature: use eth_getBlockReceipts instead of fetching receipts individually#131
Open
luborepka wants to merge 3 commits intostreamingfast:developfrom
Open
feature: use eth_getBlockReceipts instead of fetching receipts individually#131luborepka wants to merge 3 commits intostreamingfast:developfrom
luborepka wants to merge 3 commits intostreamingfast:developfrom
Conversation
luborepka
changed the title
maoueh
requested changes
Mar 18, 2026
| switch method { | ||
| case "eth_getBlockReceipts": | ||
| // Simulate unsupported method | ||
| w.Write([]byte(`{"jsonrpc":"2.0","id":"0x1","error":{"code":-32601,"message":"method not found"}}`)) |
Contributor
There was a problem hiding this comment.
Have you validated against some providers? I have the feeling this might need to be adaptative. See other comment about conditional fallback.
Comment on lines
+152
to
+155
| out, err = fetchBlockReceipts(ctx, block, client, allowEmptyReceiptsOnBlock0) | ||
| if err == nil { | ||
| return out, nil | ||
| } |
Contributor
There was a problem hiding this comment.
I would like that we conditionally decide to fallback to individual fetch only on method not found errors. In all other cases, the error should be returned directly.
Ideally also, we would have a form of caching of the fact that this client don't support it and on next invocation would straight skip to individual. I'm fine with a FIXME for now and merge without this optional feature.
| return nil, fmt.Errorf("fetching block receipts: %w", err) | ||
| } | ||
|
|
||
| out = make(map[string]*rpc.TransactionReceipt) |
Contributor
There was a problem hiding this comment.
Pre-allocated the array since we know the size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires eth-go PR- MergedCloses: #130