Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added carousel for screenshot section #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Isma1306
Copy link
Collaborator

I've been quite busy lately but I've managed to get some free time.

I just added a responsive carousel for the screenshots, now the section will look a lot better specially on mobile.

Check it and if you like it you can merge it. Let me know what do you think!

I've been quite busy lately but I've managed to get some free time.

 I just added a responsive carousel for the screenshots, now the section will look a lot better specially on mobile.

Check it and if you like it you can merge it.  Let me know what do you think!
@jonaski
Copy link
Member

jonaski commented May 15, 2021

Sorry, but I like the current approach better. I like that you can see all the thumbnails of all screenshots with a transparent background without scrolling to the right. Even though I think perhaps we could reduce the number of screenshots to 8, drop the settings ones. This would help the mobile experience a bit, since you don't have to scroll that long to get to the bottom, other than that I think the mobile experience is good enough.
The only thing I think could be improved is that the popup of the screenshot could be without the frame with just the text below with transparency like the text has on the thumbnail view.
I'm very happy with your work, it's a lot better than if I had done it myself.
I suggest that we can keep this alternative version on this branch in case I change my mind.

@Isma1306
Copy link
Collaborator Author

Don't worry, it has to like you.

Yes, maybe making it 8 would be better, let me know if you need some help with that.

Ok, I will change the popup and then I will consider finished the page, but if you need anything at all just let me know and I will help you.

I did this just because I think that your project is really cool and I wanted to contribute in some way and I don't have much money hahaha.

@jonaski
Copy link
Member

jonaski commented May 16, 2021

One thing I notice now is that when you click the menu, for example about, it scrolls down beyond the start of the about section. Preferable it should stop on the headline, and still show the headline.
I'm not sure if it's always been like that, or not.
I've tested both firefox and chrome, save behavior, not sure how to fix it.

@jonaski
Copy link
Member

jonaski commented May 20, 2021

Strangely it works with Firefox now, but not Chrome

@Isma1306
Copy link
Collaborator Author

Strangely it works with Firefox now, but not Chrome
I just checked it, yes, it is very strange, everything works the same but that, I will try another solution and send it as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants