refactor(jd-client): robust error handling for initialization and retry logic#456
Open
nulllpc wants to merge 1 commit intostratum-mining:mainfrom
Open
refactor(jd-client): robust error handling for initialization and retry logic#456nulllpc wants to merge 1 commit intostratum-mining:mainfrom
nulllpc wants to merge 1 commit intostratum-mining:mainfrom
Conversation
nulllpc
force-pushed
the
npc/refactor-non-critical-jdc-errors
branch
from
90ed53b to
a541334
Compare
nulllpc
changed the title
Shourya742
reviewed
Apr 26, 2026
Member
Shourya742
left a comment
Shourya742
left a comment
There was a problem hiding this comment.
Overall approach looks good.
nulllpc
force-pushed
the
npc/refactor-non-critical-jdc-errors
branch
4 times, most recently
from
3d9b16b to
aaece78
Compare
Author
|
Hi @Shourya742 I updated my PR accordingly, I reviewed the changes made in #467 and I think my changes still align well with changes there and the comment you made here |
Shourya742
requested changes
May 1, 2026
Member
Shourya742
left a comment
Shourya742
left a comment
There was a problem hiding this comment.
Changes look okay to me. As a rule of thumb, avoid adding side effects in combinators. Once we fix this, I will approve it.
Author
|
I addressed all comments, please review again @Shourya742 |
Shourya742
reviewed
May 2, 2026
Member
|
@nulllpc once you fix the clippy and fmt nits, I’ll approve. Nice work. |
Author
|
All done! Let's get this merged, this is my first PR for sv2. Thanks for your reviews @Shourya742 |
Member
|
@nulllpc can you squash the commits. |
nulllpc
force-pushed
the
npc/refactor-non-critical-jdc-errors
branch
from
7979589 to
f3c949c
Compare
Author
|
Done! @Shourya742 I double-checked commit message as well |
nulllpc
force-pushed
the
npc/refactor-non-critical-jdc-errors
branch
from
f3c949c to
42587c2
Compare
Author
|
Hi @Shourya742 can we merge this PR, are we waiting for sth? |
nulllpc
force-pushed
the
npc/refactor-non-critical-jdc-errors
branch
2 times, most recently
from
7fbbd5d to
105844a
Compare
panicking Replaces several `expect()` and `unwrap()` calls in `JobDeclaratorClient::start` with proper error propagation using `Result`. - Updated `start()` signature to return `JDCError<JobDeclarationClient>`. - Introduced `InitializationError(String)` variant to `JDCErrorKind` to preserve context from formerly panicking calls. - Updated `main.rs` and integration tests to handle the new `Result` type - Fix clippy and fmt checks
nulllpc
force-pushed
the
npc/refactor-non-critical-jdc-errors
branch
from
105844a to
7af9c03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#168
This PR attempts to improve error handling for JDC by addressing some low-hanging improvements:
expect()andunwrap()calls inJobDeclaratorClient::startwith proper error propagation usingResult.Changes:
start()signature to returnJDCError<JobDeclarationClient>.InitializationError(String)variant toJDCErrorKindto preserve context from formerly panicking calls.main.rsand integration tests to handle the newResulttypetry_initialize_singleis updated to inspect theActionfrom sub-component errors and return a fullJDCErrorwith either aShutdownorFallbackaction.initialize_jdnow checkse.action. It immediately propagates fatalShutdownerrors up tostart()while continuing to retry onFallbackerrors.Actionenum now derivesPartialEqandEqto enable this logic.JDCResulttype alias.