Make RHEL 9 and RHEL 10 cargo_test arguments consistent

[mulkieran]

Closes #559

Summary by CodeRabbit

• Tests
  • Simplified test gating so checks now always run in "no-run" mode when checks are enabled, removing per-RHEL conditional behavior and making CI test execution consistent across releases.
• Chores
  • Updated build/test gating logic to streamline the check phase without changing build or install behavior.

[coderabbitai]

Walkthrough

The spec file changes adjust the RHEL version check in the %check section from “0%{?rhel} < 10” to “0%{?rhel} < 9,” shifting which RHEL versions use the first cargo_test branch (no-run) versus the alternate. Only the test execution gating is modified; build and install steps are unchanged.

Changes

Cohort / File(s)	Summary
Spec test gating mockbuild_test/stratisd.spec	Updated %check conditional from RHEL < 10 to RHEL < 9, changing which RHEL versions run the initial cargo_test invocation in no-run mode; no other sections modified.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Builder
  participant RPM as RPM Spec (%check)
  participant Cargo as cargo_test

  Builder->>RPM: Enter %check
  alt RHEL < 9
    note over RPM: First branch (no-run)
    RPM->>Cargo: cargo test --no-run
    RPM->>Cargo: (Subsequent steps per spec)
  else RHEL ≥ 9
    note over RPM: Alternate branch (execute tests)
    RPM->>Cargo: cargo test (run)
    RPM->>Cargo: (Subsequent steps per spec)
  end
  Builder-->>RPM: Continue build/install (unchanged)

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A nibble of spec, a hop through time,
RHEL 9 joins 10—now tests align.
I twitch my nose at branching fate,
Less zig, more zag—oh how first-rate!
Thump-thump, I merge with cheerful paws,
One clean check for Rusty laws.

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues Check	✅ Passed	Linked issue #559 requests that RHEL 9 use the same cargo_test options as RHEL 10 due to a Rust 1.90 toolchain change; the PR updates the spec %check conditional from 0%{?rhel} < 10 to 0%{?rhel} < 9, which moves RHEL 9 into the same branch as RHEL 10 and thereby aligns their cargo_test invocations. The modification is limited to the %check section per the provided summary and addresses the coding objective stated in the linked issue. Based on the provided summary, the change implements the requested behavior.
Out of Scope Changes Check	✅ Passed	The raw summary shows a single, focused change in mockbuild_test/stratisd.spec (adjusting the RHEL threshold in the %check section) and explicitly notes no changes to exported or public entities; there are no other file modifications or unrelated changes reported. Therefore there is no evidence of out-of-scope changes in the provided summary. The PR appears limited to the intended spec adjustment.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly describes the main change of aligning cargo_test arguments between RHEL 9 and RHEL 10 by updating the spec file gating logic, matching the PR’s core purpose.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}