Skip to content

Commit

Permalink
Fix stateful set environment variables (#25)
Browse files Browse the repository at this point in the history
**Description** When disabling orchestrator groups, the end to that if
condition wasn't properly scoped and included the env and envValueFrom
sections

**Testing** `helm template` and viewed the output with a values file
that contained `env` and `envValueFrom` sections.

**Documentation** N/A

Signed-off-by: Warren Fernandes <[email protected]>
  • Loading branch information
wfernandes authored Sep 15, 2023
1 parent 91cedbc commit f328a1b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/orchestrator/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type: application
# This is the chart version. This version number should be incremented each time we
# make changes to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.10
version: 0.1.11

# This is the version number of the application being deployed. This version number
# should be incremented each time we make changes to the application. Versions are
Expand Down
2 changes: 1 addition & 1 deletion charts/orchestrator/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ spec:
{{ end }}
- name: MAVERICS_GROUPS_PRIMARY_NODE_KEY_FILE
value: /etc/maverics/groups/tls/primary-key
{{- end }}
{{- range $key, $value := .Values.env }}
- name: "{{ tpl $key $ }}"
value: "{{ tpl (print $value) $ }}"
Expand All @@ -87,7 +88,6 @@ spec:
valueFrom:
{{- tpl (toYaml $value) $ | nindent 16 }}
{{- end }}
{{- end }}
{{- if or .Values.envFromSecrets .Values.envFromConfigMaps}}
envFrom:
{{- range .Values.envFromSecrets }}
Expand Down

0 comments on commit f328a1b

Please sign in to comment.