Skip to content

Conversation

@foxxqin
Copy link
Contributor

@foxxqin foxxqin commented Aug 8, 2025

Description

Fix: Workflow tasks cannot get the result from previous dependent tasks.

In https://github.com/strands-agents/tools/blob/main/src/strands_tools/workflow.py
the code:
content = result.get("content", []) if hasattr(result, "get") else getattr(result, "content", [])
is supposed to get the result from previous tasks and save it in the context for later use.

However, the code cannot parse the object of AgentResult type and get the result from the agent run.

I also updated the test cases in tests/test_workflow.py to mock up the ActionResult return value.

Related Issues

#201

Documentation PR

No need to update the documentation, as it's the expected behavior from the workflow tool.

Type of Change

Bug fix

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@foxxqin foxxqin requested a review from a team as a code owner August 8, 2025 09:09
cagataycali
cagataycali previously approved these changes Oct 30, 2025
zastrowm
zastrowm previously approved these changes Nov 5, 2025
@zastrowm zastrowm marked this pull request as draft November 5, 2025 13:32
@zastrowm zastrowm marked this pull request as ready for review November 5, 2025 13:32
@zastrowm zastrowm enabled auto-merge (squash) November 5, 2025 13:33
@zastrowm zastrowm dismissed stale reviews from cagataycali and themself via c7b9c59 November 5, 2025 14:42
@zastrowm zastrowm force-pushed the fix/workflow-task-dependency-results branch from c074afc to c7b9c59 Compare November 5, 2025 14:42
@zastrowm zastrowm merged commit 0014a2b into strands-agents:main Nov 5, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants