Release: Prerelease 10.0.0-beta.13 #32734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `fix-faux-esm-require` to analyze compatibility needs for ESM files, including checks for `require` and `__dirname` usage. - Added new tests to validate the detection of `__dirname` and `require` usage, as well as the generation of appropriate compatibility banners. - Refactored the `getRequireBanner` function to conditionally include necessary imports and constants based on the analyzed compatibility needs. - Improved overall test coverage for compatibility analysis and banner generation.
- Replaced `analyzeCompatibilityNeeds` with direct checks for `require`, `__dirname`, and `__filename` usage in `fix-faux-esm-require`. - Updated tests to reflect changes in compatibility checks and ensure accurate detection of ESM features. - Simplified banner generation logic by removing unnecessary functions and consolidating import handling. - Enhanced overall test coverage for the updated compatibility analysis and migration process.
- Enhanced the `fix-faux-esm-require` functionality by refining the logic for inserting `__filename`, `__dirname`, and `require` declarations after import statements. - Updated test cases to ensure accurate validation of the new insertion behavior and compatibility checks. - Improved code readability and maintainability by restructuring variable declarations and insertion indices.
- Updated the `fix-faux-esm-require` implementation to utilize `import.meta.url` directly instead of using string literals for `__filename` and `require` declarations. - Adjusted test cases to reflect the changes in the handling of ESM imports and ensure accurate validation of the new logic.
- Added new tests to validate detection of `__dirname` in various contexts, including strings and comments. - Refactored `containsDirnameUsage` to utilize a new `containsPatternUsage` function for improved pattern matching. - Updated `fix-faux-esm-require` to leverage the new `containsDirnameUsage` and `containsFilenameUsage` functions for better compatibility checks.
- Deleted the `hasImport` function from `mainConfigFile.ts` to streamline import detection logic. - Removed corresponding tests from `mainConfigFile.test.ts` to reflect the function's removal and maintain test accuracy.
- Added checks to ensure that `__filename`, `__dirname`, and `require` declarations are not duplicated when they already exist in the code. - Introduced new tests to validate the prevention of duplicate declarations in various scenarios. - Improved the logic for inserting declarations after import statements, enhancing overall compatibility and correctness.
- Modified the `fixFauxEsmRequire` logic to only add imports for `createRequire`, `dirname`, and `fileURLToPath` based on their actual usage in the code. - Updated tests to reflect the changes in import handling and ensure accurate validation of the new conditional logic.
…-note Docs: Fix main.js/preset migration note
…-automigration Upgrade: Enhance ESM compatibility checks and banner generation
github-actions
bot
requested review from
jonniebigodes and
kylegach
as code owners
github-actions
bot
added
the
release
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
…ig_snippet_with_csf4 Docs: Fix A11y preview configuration example
storybook-bot
force-pushed
the
version-non-patch-from-10.0.0-beta.12
branch
from
f0f8922 to
546085c
Compare
…ng-annotations CLI: CSF factories codemod - support annotations in npx context
storybook-bot
force-pushed
the
version-non-patch-from-10.0.0-beta.12
branch
from
546085c to
a4c3974
Compare
Move: Addon jest into it's own repository
storybook-bot
force-pushed
the
version-non-patch-from-10.0.0-beta.12
branch
from
a4c3974 to
ea560e1
Compare
yannbf
added
freeze
|
View your CI Pipeline Execution ↗ for commit ea560e1
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
10.0.0-beta.12to10.0.0-beta.13.Once this pull request is merged, it will trigger a new release of version
10.0.0-beta.13.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
10.0.0-beta.13