[PRO-284] fix support sync component internal tags

[alvarosabu]

Pull request type

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Other (please describe):

How to test this PR

• Go to vscode
• Run & Debug tab
• Run "Launch CLI Script"
• Check result on debug console.
• (Optional) Check the spaces directly (295017, 295018)

What is the new behavior?

• Added internal logic to handle component internal tags (Will only create tags on target if they don't exist yet)
• Tested creation of new component with tags if it doesn't exist on target space
• Tested update of component with tags if it already exists on target space

Other information

I had to force the updated component internal_tag_ids to always be like the source component because the current solution mergeComponents is not recursive and is not merging the array correctly. I don't think is worth to refactor mergeComponents right now since we plan other things for this package in the near future.

 payload.component.internal_tag_ids = sourceComponentData.internal_tag_ids;

updateComponent(spaceId, componentId, sourceComponentData, targetComponentData) {
    const payload = {
      component: this.mergeComponents(
        sourceComponentData,
        targetComponentData
      )
    };
    payload.component.internal_tag_ids = sourceComponentData.internal_tag_ids;
    return this.client.put(`spaces/${spaceId}/components/${componentId}`, payload).then((response) => {
      const component = response.data.component || {};
      return component;
    }).catch((error) => Promise.reject(error));
  }

[notion-workspace]

PR for adding component internal tags logic

[Edo-San]

LGTM 👍
Agreed with your take on the refactoring of the mergeComponents function: that's probably not worth it right now.

As for the tests, well.. They should be heavily refactored alongside the rest of this repo, so I wouldn't bother with them as for now 😅 My 2 cents.

Thanks for this PR @alvarosabu 🙏 MUCH appreciated! I love tags as opposed to folders, even tho the support is a bit lackluster as for now, but they're a new feature and I'm looking forward to use them more and more in the future and eventually replace all the folders with tags!

[christianzoppi]

Thanks @alvarosabu! I agree with you and @Edo-San on the comment about the mergeComponents function.

I also tested the function to see if I could spot any edge case, but so far all good. You have done a great job so quickly! 🙏🏻

[github-actions]

🎉 This issue has been resolved in version 3.32.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀