Skip to content

Conversation

@xuezhaojun
Copy link
Contributor

Summary

This PR updates the following dependencies to their latest versions:

  • github.com/openshift/hive/apis to master branch (v0.0.0-20251118235423-715614a9f379)
  • k8s.io/api, k8s.io/client-go, k8s.io/apiserver to v0.33.3
  • Multiple transitive dependencies updated as part of the upgrade

Changes

  1. Dependency Updates: Updated hive APIs and aligned Kubernetes dependencies to v0.33.3
  2. Code Fix: Fixed a linting issue in pkg/klusterlet/clusterclaim/schedulable.go:96
    • Changed klog.Infof(msg) to klog.Info(msg) to resolve non-constant format string error
  3. Vendor Updates: Ran go mod tidy and go mod vendor to update vendor directory

Testing

  • make build - All builds successful
  • make test - All tests passing

Notes

  • The dependency updates were necessary to maintain compatibility with the latest hive APIs
  • Kubernetes dependencies were aligned to the same version (v0.33.3) to avoid version conflicts
  • All changes are backward compatible

🤖 Generated with Claude Code

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xuezhaojun
Once this PR has been reviewed and has the lgtm label, please assign qiujian16 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xuezhaojun xuezhaojun force-pushed the update-hive-apis-backplane-2.7 branch 2 times, most recently from a98e663 to 7603d2f Compare November 19, 2025 08:56
@xuezhaojun
Copy link
Contributor Author

/retest

@xuezhaojun xuezhaojun force-pushed the update-hive-apis-backplane-2.7 branch 2 times, most recently from bd71be1 to b3def09 Compare November 20, 2025 04:06
@xuezhaojun
Copy link
Contributor Author

/retest

This commit updates the following dependencies:
- github.com/openshift/hive/apis to master branch
- k8s.io/api, k8s.io/client-go, k8s.io/apiserver to v0.33.3
- Multiple transitive dependencies

Also fixed a linting issue in pkg/klusterlet/clusterclaim/schedulable.go:
- Changed klog.Infof(msg) to klog.Info(msg) to avoid non-constant format string error

All tests passing after these updates.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: xuezhaojun <[email protected]>
@xuezhaojun xuezhaojun force-pushed the update-hive-apis-backplane-2.7 branch from b3def09 to f2dd0b3 Compare November 20, 2025 07:00
@sonarqubecloud
Copy link

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

@xuezhaojun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-deps f2dd0b3 link true /test verify-deps
ci/prow/e2e f2dd0b3 link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xuezhaojun xuezhaojun merged commit 5f71933 into stolostron:backplane-2.7 Nov 20, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant