Skip to content

bxCAN impl #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2021
Merged

bxCAN impl #224

merged 3 commits into from
Jun 6, 2021

Conversation

korken89
Copy link
Collaborator

@korken89 korken89 commented May 2, 2021

No description provided.

@korken89 korken89 marked this pull request as draft May 2, 2021 19:31
@korken89 korken89 marked this pull request as ready for review May 31, 2021 11:23
@korken89
Copy link
Collaborator Author

Now tested working, and example added!

@korken89
Copy link
Collaborator Author

Hmm, after some thinking I'll clean it up some more.
I don't like the interface I based it on from the F4 HAL - this is not type safe.

@korken89 korken89 marked this pull request as draft May 31, 2021 11:52
@korken89 korken89 marked this pull request as ready for review May 31, 2021 12:23
@korken89
Copy link
Collaborator Author

Sorry for the extra noise @MathiasKoch :)

@korken89
Copy link
Collaborator Author

korken89 commented Jun 6, 2021

Ping @MathiasKoch :)

@MathiasKoch
Copy link
Collaborator

Oh, this somehow fell of my radar 🤔 but i think it looks good! Unfortunately I have no hardware to test it, but i can confirm it doesn't break anything of mine at least 😊

@korken89
Copy link
Collaborator Author

korken89 commented Jun 6, 2021

Thanks!

@korken89 korken89 merged commit e5327cd into master Jun 6, 2021
@korken89 korken89 deleted the bxcan branch June 6, 2021 18:05
@pdgilbert
Copy link

This merge has broken testing with multiple HALs for the reason described in the links in #235.

@korken89
Copy link
Collaborator Author

korken89 commented Jun 6, 2021

@pdgilbert See PR #236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants