Skip to content

Added all available USART2 pins #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

mcopela
Copy link

@mcopela mcopela commented Apr 3, 2020

The serial file only has one set of USART2 pins under the STM32l0x1 feature flag, while the STM32l031 setting sheet lists four.

I added all the available USART2 pins and tested on my Nucleo-L031K6 evaluation board.

@dbrgn
Copy link
Contributor

dbrgn commented Apr 3, 2020

See #68, which also does this (I think), but is probably wrong as well for some devices in the STM32l0x1 family.

I'm working on a PR that fixes this for all MCUs by basing the cfg flags on the io-* features, just like #87 but for UART.

@dbrgn
Copy link
Contributor

dbrgn commented Apr 3, 2020

This should now be fixed in #68.

@mcopela testing that branch would be very welcome! It also includes an API change, where the Pins trait is replaced with RxPin and TxPin (as discussesd in #67).

@arkorobotics
Copy link
Member

@dbrgn Shall we close this PR given #68 is complete/merged?

@dbrgn
Copy link
Contributor

dbrgn commented Apr 5, 2020

@arkorobotics I would say so, #68 includes the changes that were proposed here!

@arkorobotics
Copy link
Member

Copy!

@mcopela
Copy link
Author

mcopela commented Apr 6, 2020

Thank you guys! I'll test the new merges today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants