Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intervention widget description #1014

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Intervention widget description #1014

wants to merge 2 commits into from

Conversation

fellmirr
Copy link
Member

Adds a description field to the intervention widget. Draft frontpage shows of for testing.

Tested on devices

  • Desktop 💻
  • Mobile 📱

Tests

  • All tests are running ✔️
  • Test are updated 🧪
  • Code Review 👩‍💻
  • QA 👌

Checkpoints

Check these to flag for a more thurough review, as they could be potentially breaking changes

  • Packages updated
  • Other infrastructure updated (such as node version or similar)

⏲️ Time spent on CR:

⏲️ Time spent on QA:

@vercel Vercel
Copy link

vercel bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ge-effektivt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 10:10am
main-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 10:10am

@cypress Cypress
Copy link

cypress bot commented Jan 31, 2025 •
edited
Loading

Main site    Run #5865

Run Properties:  status check failed Failed #5865  •  git commit c6dceaf098: Removes passhref from links
Project Main site
Run status status check failed Failed #5865
Run duration 00m 54s
Commit git commit c6dceaf098: Removes passhref from links
Committer Håkon Harnes
View all properties for this run ↗︎
Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 61

Tests for review

Failed  agreements.js • 1 failed test • GiEffektivt e2e tests

View Output

Test Artifacts
Agreements page > Should display correct information in expanded view Test Replay Screenshots
Failed  yearly-reports-missing-ssn.js • 2 failed tests • GiEffektivt e2e tests

View Output

Test Artifacts
Tax reports page missing ssn > should should show warning if missing ssn Test Replay Screenshots
Tax reports page missing ssn > should display row with donations missing tax units Test Replay Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fellmirr