Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a tax deduction calculation component #1013

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fellmirr
Copy link
Member

Adds a calculator to visualise tax deductions, available at /tax-widget-test for testing.


Tested on devices

  • Desktop 💻
  • Mobile 📱

Tests

  • All tests are running ✔️
  • Test are updated 🧪
  • Code Review 👩‍💻
  • QA 👌

Checkpoints

Check these to flag for a more thurough review, as they could be potentially breaking changes

  • Packages updated
  • Other infrastructure updated (such as node version or similar)

⏲️ Time spent on CR:

⏲️ Time spent on QA:

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ge-effektivt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 4:37pm
main-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 4:37pm

Copy link

cypress bot commented Jan 28, 2025

Main site    Run #5823

Run Properties:  status check failed Failed #5823  •  git commit 81cadba485: Adds a tax deduction calculation component
Project Main site
Run status status check failed Failed #5823
Run duration 00m 48s
Commit git commit 81cadba485: Adds a tax deduction calculation component
Committer Håkon Harnes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 61

Tests for review

Failed  agreements.js • 1 failed test • GiEffektivt e2e tests

View Output

Test Artifacts
Agreements page > Should display correct information in expanded view Test Replay Screenshots
Failed  yearly-reports-missing-ssn.js • 2 failed tests • GiEffektivt e2e tests

View Output

Test Artifacts
Tax reports page missing ssn > should should show warning if missing ssn Test Replay Screenshots
Tax reports page missing ssn > should display row with donations missing tax units Test Replay Screenshots

@EliseAndresen
Copy link
Contributor

  • Title has bigger font than title in paragraph on mobile (too similar to not be the same)

  • Box does not go all the way up to the 25 000 kr line when 25 000 is entered
    image

  • Title should be aligned with the top of the 25 k line
    image

  • Make the ticks that indicate sum a bit longer?

  • Not sure if we need the “check” in the buttons of pre-filled sums. If we want to keep them I would give them at least a few px space between the check and the tekst in the buttons.

  • We should stick to the convention of the kr input in our widgets being a line.
    image
    image

  • The bar showing donations and amount payed back could be skinnier on desktop and we can leave a bit more space between it and the text.
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants