[Feature] Deploy swedish admin #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorentzlasson
commented
Apr 18, 2023
| @@ -0,0 +1,2 @@ | |||
| HOST=localhost | |||
There was a problem hiding this comment.
Is this used for anything? AFAIK know REACT_APP_* envs are let through
There was a problem hiding this comment.
I have no idea? 🤷 Global search for process.env.HOST or similar should yield results if it's used.
clouddeploy.yml
Outdated
| name: 'gcr.io/cloud-builders/npm' | ||
| env: ['CI=true', 'REACT_APP_API_URL=https://data.gieffektivt.no'] | ||
| args: ['run', 'build'] | ||
| waitFor: ['test'] |
There was a problem hiding this comment.
Should run the build & deploy steps in parallel at least
lorentzlasson
force-pushed
the
allow-configurable-api-url-355
branch
2 times, most recently
from
c6b6fdf to
4e10d5e
Compare
lorentzlasson
force-pushed
the
allow-configurable-api-url-355
branch
from
4e10d5e to
5e6a23e
Compare
adamalfredsson
approved these changes
Apr 18, 2023
lorentzlasson
commented
Apr 18, 2023
|
|
||
| - id: 'build-norway' | ||
| name: 'gcr.io/cloud-builders/npm' | ||
| env: ['CI=true', 'REACT_APP_API_URL=https://data.gieffektivt.no'] |
There was a problem hiding this comment.
NO dev is using the same backend from what I can tell? But also login doesn't work it seems 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggering two parallel deploys for SE and NO when pushed to master.
Haven't tested the full deployment flow, but tested the swedish subset here. Would like to try out the dev flow before merging
#355
Tested on devices
Tests
⏲️ Time spent on CR:
⏲️ Time spent on QA: