fix: add WAL checkpoint robustness with retry logic #1281
+1,498
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add WAL checkpoint retry logic with exponential backoff to prevent data loss when concurrent readers hold locks during database close. Security fixes from SECURITY_AUDIT.md: - Issue steveyegge#8: WAL checkpoint failure silently losing data Changes: - Add 5-retry exponential backoff for WAL checkpoint in Close() - Warn user if checkpoint fails after retries (potential data loss) - Add flush_manager_race_test.go for concurrency testing - Add wal_test.go for checkpoint with concurrent readers Co-Authored-By: SageOx <ox@sageox.ai>
rsnodgrass
force-pushed
the
pr/sync-flush-robustness
branch
from
efcef23 to
63c8da9
Compare
rsnodgrass
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
store.go: Add 5-retry exponential backoff for WAL checkpoint in Close()flush_manager_race_test.go: Concurrency tests for flush managerwal_test.go: Tests for checkpoint with concurrent readersSecurity Fixes
Test Plan
go test -race ./cmd/bd/... -run FlushManagerfor flush testsgo test -race ./internal/storage/sqlite/... -run WALfor WAL testsRelated Issues
sequenceDiagram participant S as Store.Close() participant W as WAL S->>W: Checkpoint (attempt 1) W-->>S: SQLITE_BUSY (reader lock) S->>S: Sleep 100ms S->>W: Checkpoint (attempt 2) W-->>S: SQLITE_BUSY S->>S: Sleep 200ms S->>W: Checkpoint (attempt 3) W-->>S: Success S->>S: Close DB