Skip to content

Conversation

@rhpot1991
Copy link

Added InsertHTML support for IE and insertFontPoint for all browsers.

Added InsertHTML support for IE and insertFontPoint for all browsers.
@codewithtyler
Copy link

Can you run jshint? The project is currently set up to use the Google style guide and I noticed that you removed the space from between the parenthesis. Running jshint should take care of that.

@spreadred
Copy link

spreadred commented Apr 4, 2017

Merging this PR results in (when clicking any toolbar button):

Uncaught TypeError: Cannot read property 'indexOf' of undefined
    at HTMLAnchorElement.<anonymous> (bootstrap-wysiwyg.js:296)
    at HTMLAnchorElement.dispatch (jquery.min.js:3)
    at HTMLAnchorElement.r.handle (jquery.min.js:3)
(anonymous) @ bootstrap-wysiwyg.js:296
dispatch @ jquery.min.js:3
r.handle @ jquery.min.js:3

It refers to this line:
else if ( editor.data( options.commandRole ).indexOf( 'fontPoint' ) >= 0 )

EDIT: this has been fixed and pushed to my fork. If you want to cherry-pick the commit, the hash is e8cdd75

@steveathon
Copy link
Owner

@rhpot1991 can you pickup the changes that @kaptainkommie made for your fork so we can close off this PR?

@steveathon
Copy link
Owner

Bump @rhpot1991 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants