Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable quietDeps and silenceDeprecations config options #600

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

dgonzalezr
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently, users need to make TS ignore available SASS options not added to the plugin type declaration. For example:

import { Config } from '@stencil/core';
import { sass } from '@stencil/sass';

export const config: Config = {
  ...
  plugins: [
    sass({
      // @ts-expect-error - silenceDeprecations is not typed in @stencil/sass config
      silenceDeprecations: ['import'],
    })
  ]
  ...
};

GitHub Issue Number: #378

What is the new behavior?

Users can now use control warnings like quietDeps and/or silenceDeprecations options in the stencil.config.ts without @ts-ignore.

import { Config } from '@stencil/core';
import { sass } from '@stencil/sass';

export const config: Config = {
  ...
  plugins: [
    sass({
      quietDepts: true,
      silenceDeprecations: ['import'],
    })
  ]
  ...
};

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@dgonzalezr dgonzalezr requested a review from a team as a code owner March 14, 2025 10:52
@dgonzalezr dgonzalezr changed the title feat: add optional quietDeps and silenceDeprecations config options feat: enable quietDeps and silenceDeprecations config options Mar 14, 2025
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit af9e115 into stenciljs:main Mar 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants