Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): include <style /> for scope components when fullDocument: false #6155

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/runtime/client-hydrate.ts
Co-authored-by: Christian Bromann <git@bromann.dev>
johnjenkins and christian-bromann authored Feb 7, 2025
commit b48a2ff2ec9deaa567bbfb6d06ef44c64a41e55e
2 changes: 1 addition & 1 deletion src/runtime/client-hydrate.ts
Original file line number Diff line number Diff line change
@@ -221,7 +221,7 @@ export const initializeClientHydrate = (
const rnLen = shadowRootNodes.length;
if (rnLen) {
for (rnIdex; rnIdex < rnLen; rnIdex++) {
shadowRoot.appendChild(shadowRootNodes[rnIdex] as any);
shadowRoot.appendChild(shadowRootNodes[rnIdex]);
}
// During `scoped` shadowDOM rendering, there's a bunch of comment nodes used for positioning / empty text nodes.
// Let's tidy them up now to stop frameworks complaining about DOM mismatches.