Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fn to expose max expiration available #1106

Merged
merged 6 commits into from
Oct 5, 2023

Conversation

leighmcculloch
Copy link
Member

What

Add fn to expose max expiration available.

Why

It came up in the Discord meeting today that it would be helpful if contracts can access the max expiration as they may wish to simply bump to that. The host fn exists, but it isn't exposed in the SDK.

@leighmcculloch leighmcculloch requested a review from dmkozh October 5, 2023 18:41
@leighmcculloch leighmcculloch marked this pull request as ready for review October 5, 2023 18:41
soroban-sdk/src/storage.rs Outdated Show resolved Hide resolved
soroban-sdk/src/ledger.rs Show resolved Hide resolved
soroban-sdk/src/storage.rs Outdated Show resolved Hide resolved
@leighmcculloch leighmcculloch requested a review from dmkozh October 5, 2023 22:08
@leighmcculloch leighmcculloch added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 05d5332 Oct 5, 2023
14 checks passed
@leighmcculloch leighmcculloch deleted the rudimentariness-fishet branch October 5, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants