Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: expose rem_euclid functions and add 128/256 bit conversions #1102

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Feature: expose rem_euclid functions and add 128/256 bit conversions #1102

merged 2 commits into from
Oct 13, 2023

Conversation

mootz12
Copy link
Contributor

@mootz12 mootz12 commented Oct 3, 2023 •
edited
Loading

What

Why

Context in env PR here: stellar/rs-soroban-env#1091

Known limitations

None

TODO:

  • update soroban-env version

@mootz12 mootz12 mentioned this pull request Oct 3, 2023
Merged
@mootz12
Copy link
Contributor Author

mootz12 commented Oct 10, 2023 •
edited
Loading

@mootz12
Copy link
Contributor Author

mootz12 commented Oct 11, 2023

cc: @dmkozh

Doesn't seem to let me add reviewers. Would you mind adding them for me?

@dmkozh dmkozh added this pull request to the merge queue Oct 13, 2023
leighmcculloch
leighmcculloch reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to consider about conversion conventions. I removed the PR from the queue for this to be considered.

soroban-sdk/src/num.rs Outdated Show resolved Hide resolved
@leighmcculloch leighmcculloch removed this pull request from the merge queue due to a manual request Oct 13, 2023
leighmcculloch
leighmcculloch approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed d5fa16e, approving and merging based on @dmkozh's earlier review.

@leighmcculloch leighmcculloch added this pull request to the merge queue Oct 13, 2023
Merged via the queue into stellar:main with commit 24f9f74 Oct 13, 2023
14 checks passed
@mootz12 mootz12 deleted the extend_256_nums branch October 13, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh approved these changes

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mootz12 @leighmcculloch @dmkozh