Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Storage::get to pub(crate) #1100

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Change Storage::get to pub(crate) #1100

merged 1 commit into from
Oct 3, 2023

Conversation

leighmcculloch
Copy link
Member

What

Change Storage::get from pub to pub(crate).

Why

The function is intended to be an internal function that the instance, temporary, and persistent types call into.

The Storage::has and Storage::set are marked as pub(crate).

Looks like we accidentally marked it as pub.

@leighmcculloch leighmcculloch marked this pull request as ready for review October 3, 2023 04:08
@leighmcculloch leighmcculloch requested review from a team and removed request for sisuresh October 3, 2023 04:08
@leighmcculloch leighmcculloch added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 3db7a43 Oct 3, 2023
@leighmcculloch leighmcculloch deleted the counterbattery-alphabetic branch October 3, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leighmcculloch @dmkozh