Skip to content

chore: delegate npm release finalization - #192

Merged
jan-kubica merged 1 commit into
mainfrom
chore/share-npm-version-finalize
Aug 26, 2026
Merged

chore: delegate npm release finalization#192
jan-kubica merged 1 commit into
mainfrom
chore/share-npm-version-finalize

Conversation

@jan-kubica

Copy link
Copy Markdown
Contributor

Delegate npm package and GitHub release finalization to the shared npm-version-finalize workflow at 7198083e27bdd963cacc0b7d70ca54fe3ec83393. Native package and PyPI publication jobs remain prerequisites.

CC on behalf of jan-kubica

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 39 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c031de2f-6cb0-49b1-9ebe-0e4265691f3c

📥 Commits

Reviewing files that changed from the base of the PR and between ba22647 and 8e25552.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

License Issues

.github/workflows/release.yml

PackageVersionLicenseIssue Type
stella/.github/.github/workflows/npm-version-finalize.yml7198083e27bdd963cacc0b7d70ca54fe3ec83393NullUnknown License
Allowed Licenses: MIT, Apache-2.0, Apache-2.0 WITH LLVM-exception, BSD-2-Clause, BSD-3-Clause, ISC, 0BSD, BlueOak-1.0.0, Unlicense, CC0-1.0, CC-BY-4.0, MIT-0, MPL-2.0, Python-2.0, Zlib, Unicode-3.0
Excluded from license check: pkg:cargo/libfuzzer-sys

OpenSSF Scorecard

PackageVersionScoreDetails
actions/stella/.github/.github/workflows/npm-version-finalize.yml 7198083e27bdd963cacc0b7d70ca54fe3ec83393 UnknownUnknown

Scanned Files

  • .github/workflows/release.yml

@jan-kubica
jan-kubica merged commit 94ba60f into main Aug 26, 2026
13 checks passed
@jan-kubica
jan-kubica deleted the chore/share-npm-version-finalize branch August 26, 2026 13:55

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e255527f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/stdnum-darwin-arm64/package.json
packages/stdnum-win32-x64-msvc/package.json
artifact-pattern: npm-tarball-*
publish-to-npm: true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Do not republish packages during finalization

Because this job waits for publish-main, which transitively waits for publish-native and publish-wasm, all seven tarballs matching this pattern have already been published by this workflow. Setting publish-to-npm: true asks the reusable finalizer to publish the same name/version combinations again; npm rejects combinations that already exist (npm publish documentation), so every publishing release can stop here after the registries have changed but before the GitHub release is created. Either let the finalizer own npm publication or invoke it without republishing.

Useful? React with 👍 / 👎.

@github-actions github-actions Bot locked and limited conversation to collaborators Aug 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant