chore: delegate npm release finalization - #192
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
|
Warning Review limit reachedNext included review available in 39 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency ReviewThe following issues were found:
License Issues.github/workflows/release.yml
OpenSSF Scorecard
Scanned Files
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e255527f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| packages/stdnum-darwin-arm64/package.json | ||
| packages/stdnum-win32-x64-msvc/package.json | ||
| artifact-pattern: npm-tarball-* | ||
| publish-to-npm: true |
There was a problem hiding this comment.
Do not republish packages during finalization
Because this job waits for publish-main, which transitively waits for publish-native and publish-wasm, all seven tarballs matching this pattern have already been published by this workflow. Setting publish-to-npm: true asks the reusable finalizer to publish the same name/version combinations again; npm rejects combinations that already exist (npm publish documentation), so every publishing release can stop here after the registries have changed but before the GitHub release is created. Either let the finalizer own npm publication or invoke it without republishing.
Useful? React with 👍 / 👎.
Delegate npm package and GitHub release finalization to the shared npm-version-finalize workflow at 7198083e27bdd963cacc0b7d70ca54fe3ec83393. Native package and PyPI publication jobs remain prerequisites.
CC on behalf of jan-kubica