Skip to content

fix: improve parity capture diagnostics#154

Merged
jan-kubica merged 2 commits into
mainfrom
fix/parity-screenshot-diagnostics
Jul 10, 2026
Merged

fix: improve parity capture diagnostics#154
jan-kubica merged 2 commits into
mainfrom
fix/parity-screenshot-diagnostics

Conversation

@jan-kubica

Copy link
Copy Markdown
Contributor

Summary

  • hide editor and playground chrome that overlaps element screenshots
  • capture a bounded tail of playground startup output
  • fail immediately when the playground process exits before readiness
  • include startup output in parity infrastructure errors

Verification

  • 24 focused parity extraction tests passed
  • visually verified clean page-only screenshot output on an anonymized fixture
  • bun audit reported no vulnerabilities
  • lint and typecheck intentionally delegated to CI

CC on behalf of @jan-kubica

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jan-kubica, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1e3ee0a9-a4f5-4b3c-9654-da926ddec285

📥 Commits

Reviewing files that changed from the base of the PR and between 4aa42ec and c731293.

📒 Files selected for processing (2)
  • parity/__tests__/folioExtract.test.ts
  • parity/folioExtract.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/parity-screenshot-diagnostics

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jan-kubica jan-kubica marked this pull request as ready for review July 10, 2026 08:51

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors screenshot styling into an exported constant and improves playground startup diagnostics by capturing and reporting stdout/stderr logs on failure. The review feedback highlights a critical deadlock and background promise leak during server startup, as well as a missing null/undefined guard for the output stream in captureOutputTail.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread parity/folioExtract.ts
Comment thread parity/folioExtract.ts Outdated
@jan-kubica jan-kubica merged commit 815947a into main Jul 10, 2026
8 checks passed
@jan-kubica jan-kubica deleted the fix/parity-screenshot-diagnostics branch July 10, 2026 09:30
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant