Skip to content

chore: bump aho-corasick to 1.0.4 - #90

Merged
jan-kubica merged 1 commit into
mainfrom
chore/bump-1.0.4
Jun 11, 2026
Merged

chore: bump aho-corasick to 1.0.4#90
jan-kubica merged 1 commit into
mainfrom
chore/bump-1.0.4

Conversation

@jan-kubica

Copy link
Copy Markdown
Contributor

Release 1.0.4: first version shipping the win32-x64-msvc native binding (follow-up to the win32 build PR).

  • version-sync sync --version 1.0.4 (VERSION, Cargo, package.jsons incl. npm/win32-x64-msvc, loader pins)
  • CHANGELOG entry

On merge, the release workflow publishes via trusted publishing — this run also validates the newly configured trusted publisher for @stll/aho-corasick-win32-x64-msvc (placeholder 0.0.1-placeholder.0 is already on the registry to bootstrap it).

CC on behalf of @jan-kubica

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project version from 1.0.3 to 1.0.4 across package manifests, lockfiles, and native binding configurations, and documents the addition of Windows support in the changelog. The feedback recommends moving the new changelog version header below the introductory paragraph to comply with the Keep a Changelog standard.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread CHANGELOG.md
@@ -1,5 +1,14 @@
# Changelog

## 1.0.4

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version header '## 1.0.4' has been placed above the introductory text of the changelog. According to the Keep a Changelog standard, the introductory paragraph ('All notable changes to this project...') should remain at the very top of the file, directly under the '# Changelog' title, and before any version headers.

@jan-kubica
jan-kubica merged commit 06f141d into main Jun 11, 2026
21 checks passed
@jan-kubica
jan-kubica deleted the chore/bump-1.0.4 branch June 11, 2026 11:20
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant